search

getsentry / sentry-react-native

Official Sentry SDK for React Native
https://sentry.io
MIT License
1.57k stars 337 forks source link

BUG: after upgrade to version >= 4.10 - sentry-testkit stopped getting reports through `transport` option #2718

Closed zivl closed 1 year ago

zivl commented 1 year ago

sentry-teskit has support for @sentry/react-native library since the begining. recently, an issue was reported from consumers who are using both @sentry/react-native and sentry-teskit, they mainly complain on support regression after moving from version @sentry/react-native@4.9.0 to versions @sentry/react-native@4.10.0 and above.

See original issue here: https://github.com/wix/sentry-testkit/issues/151

I was trying to debug and catch what has been changed but so far i'm out of explanations. I did succeed in reproducing the issue in 100%. This is the PR which contains the code to easily reproduce the issue: https://github.com/wix/sentry-testkit/pull/154

SDK: "@sentry/react-native": "4.9.0",

SDK version: 0.0.0

react-native version: 0.70.6

Are you using Expo?

Steps to reproduce:

krystofwoldrich commented 1 year ago

Hi, thanks for the info, there was JS SDK lib bump up in 4.10.0. Maybe something changed there.

I can reproduce the issue, I'll take a look and let you know @zivl. I'm not familiar with sentry-teskit so I might have some questions.

zivl commented 1 year ago

@krystofwoldrich sure! i'll be happy to help where ever i can 💪

krystofwoldrich commented 1 year ago

@zivl It was the ModulesLoader integration throwing an error because the native was not available. Here is the fix.

zivl commented 1 year ago

WOW thanks @krystofwoldrich 🥇 I'll keep an eye to see when it was released and I'll validate on my end as well

krystofwoldrich commented 1 year ago

The https://github.com/getsentry/sentry-react-native/releases/tag/4.13.0 is out. @zivl you can try it.

zivl commented 1 year ago

@krystofwoldrich yes! yesterday I had users who reported the issue has been resolved 🥇 I appreciate your effort on this, thank you!

jfaris commented 1 year ago

Version 4.13.0 fixes the issue for us. Thank you @krystofwoldrich for the quick turnaround!