search

getsentry / sentry-react-native

Official Sentry SDK for React-Native
https://sentry.io
MIT License
1.54k stars 323 forks source link

misc(sample): Add react-native-macos to bare RN sample #3785

Closed krystofwoldrich closed 3 weeks ago

krystofwoldrich commented 1 month ago

:loudspeaker: Type of change

:scroll: Description

Screenshot 2024-04-29 at 12 59 26

:green_heart: How did you test it?

CI - simple legacy (default) architecture builds test ensuring the happy path works

until official support this is sufficient, we don't have to test for new architecture

:pencil: Checklist

skip-changelog

github-actions[bot] commented 1 month ago

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 403.38 ms 426.65 ms 23.27 ms
Size 17.73 MiB 19.94 MiB 2.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c9ca10ac3f729d1b3ef805328665aa0895+dirty 338.94 ms 354.87 ms 15.93 ms
6e8584e8f1988b33cc24c85f32711c91358905fa 447.10 ms 474.71 ms 27.61 ms
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 333.78 ms 343.94 ms 10.16 ms
25343377820b65409b646b44bc8e9bc9fbb51c8c 394.15 ms 415.12 ms 20.97 ms
f06c879d164a5bd44945c6e000e25ce3f7c14172 408.41 ms 424.54 ms 16.13 ms
15c80abcaf3bedf5d6f15c0eebefc9e7c1524da1+dirty 336.27 ms 350.58 ms 14.31 ms
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 335.72 ms 355.52 ms 19.80 ms
9c48b2c9eb6422d8d51fcf56b1b4ab7841d2ec8a 349.24 ms 385.96 ms 36.72 ms
0677344f8502b3ae15a3128bf239cf5571b92443 327.74 ms 337.14 ms 9.40 ms
544699261cd72e3efc1259ba66b138f5f70a05ed 403.40 ms 426.70 ms 23.30 ms

App size

Revision Plain With Sentry Diff
d197b5c9ca10ac3f729d1b3ef805328665aa0895+dirty 17.73 MiB 20.04 MiB 2.31 MiB
6e8584e8f1988b33cc24c85f32711c91358905fa 17.73 MiB 19.86 MiB 2.12 MiB
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 17.73 MiB 19.75 MiB 2.02 MiB
25343377820b65409b646b44bc8e9bc9fbb51c8c 17.73 MiB 19.84 MiB 2.11 MiB
f06c879d164a5bd44945c6e000e25ce3f7c14172 17.73 MiB 19.85 MiB 2.12 MiB
15c80abcaf3bedf5d6f15c0eebefc9e7c1524da1+dirty 17.73 MiB 20.04 MiB 2.31 MiB
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 17.73 MiB 20.04 MiB 2.31 MiB
9c48b2c9eb6422d8d51fcf56b1b4ab7841d2ec8a 17.73 MiB 19.80 MiB 2.07 MiB
0677344f8502b3ae15a3128bf239cf5571b92443 17.73 MiB 19.81 MiB 2.07 MiB
544699261cd72e3efc1259ba66b138f5f70a05ed 17.73 MiB 19.85 MiB 2.12 MiB
github-actions[bot] commented 1 month ago

Android (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 372.00 ms 392.92 ms 20.92 ms
Size 7.15 MiB 8.21 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f06c879d164a5bd44945c6e000e25ce3f7c14172+dirty 361.27 ms 407.88 ms 46.61 ms
d197b5c9ca10ac3f729d1b3ef805328665aa0895+dirty 258.75 ms 313.61 ms 54.86 ms
1d86dd6360b3a0207437816b46e13d91fdeaf4aa+dirty 335.76 ms 371.22 ms 35.46 ms
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 363.19 ms 370.37 ms 7.18 ms
728164bd341a3b0e14876d86101c4bcca5b1f1ed+dirty 335.93 ms 342.94 ms 7.01 ms
e2b64fed057d4b01cf7ad79eb19eb3c8b8002a82+dirty 258.82 ms 304.26 ms 45.44 ms
0db0c729a4ac7c205a44cb4702fa7ba5b0bc03c0+dirty 335.20 ms 351.06 ms 15.86 ms
d361d3886b2303280797f653160c781700570edf+dirty 257.72 ms 318.76 ms 61.04 ms
ad6c2993f6b77abbcf4094d17dd1fa9f7742ae99+dirty 336.47 ms 362.89 ms 26.42 ms
27ef4ee6faa6d5229b16fca7b728ca6b689ab916+dirty 296.71 ms 351.00 ms 54.29 ms

App size

Revision Plain With Sentry Diff
f06c879d164a5bd44945c6e000e25ce3f7c14172+dirty 7.15 MiB 8.12 MiB 997.78 KiB
d197b5c9ca10ac3f729d1b3ef805328665aa0895+dirty 7.15 MiB 8.09 MiB 962.72 KiB
1d86dd6360b3a0207437816b46e13d91fdeaf4aa+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 7.15 MiB 8.04 MiB 910.84 KiB
728164bd341a3b0e14876d86101c4bcca5b1f1ed+dirty 7.15 MiB 8.12 MiB 997.71 KiB
e2b64fed057d4b01cf7ad79eb19eb3c8b8002a82+dirty 7.15 MiB 8.07 MiB 947.16 KiB
0db0c729a4ac7c205a44cb4702fa7ba5b0bc03c0+dirty 7.15 MiB 8.04 MiB 911.02 KiB
d361d3886b2303280797f653160c781700570edf+dirty 7.15 MiB 8.08 MiB 959.34 KiB
ad6c2993f6b77abbcf4094d17dd1fa9f7742ae99+dirty 7.15 MiB 8.04 MiB 912.17 KiB
27ef4ee6faa6d5229b16fca7b728ca6b689ab916+dirty 7.15 MiB 8.08 MiB 959.49 KiB
krystofwoldrich commented 4 weeks ago

@brustolin Thank you, the CI error are unrelated, fixed here -> https://github.com/getsentry/sentry-react-native/pull/3793