getsentry / sentry-react-native

Official Sentry SDK for React Native
https://sentry.io
MIT License
1.57k stars 337 forks source link

`expo run:android --variant Release` doesn't trigger automatic source map upload #3907

Open krystofwoldrich opened 4 months ago

krystofwoldrich commented 4 months ago

Description

After running npx expo run:android --variant Release --no-build-cache in the samples/expo the task :app:createBundleReleaseJsAndAssets is executed, but :app:createBundleReleaseJsAndAssets_SentryUpload is not.

╰─ npx expo run:android --variant Release --no-build-cache                                                                                                 ─╯
› Port 8081 is running sentry-react-native-sample in another window
  /Users/krystofwoldrich/repos/sentry-react-native/samples/react-native (pid 82622)
✔ Use port 8082 instead? … yes
› Building app...
Configuration on demand is an incubating feature.

> Configure project :expo

Using expo modules
  - expo-constants (15.4.5)
  - expo-file-system (16.0.7)
  - expo-font (11.10.3)
  - expo-keep-awake (12.8.2)
  - expo-modules-core (1.11.9)
  - expo-modules-core$android-annotation-processor (1.11.9)
  - expo-modules-core$android-annotation (1.11.9)
  - expo-splash-screen (0.26.4)
  - expo-web-browser (12.8.2)

> Task :expo:compileReleaseKotlin
w: file:///Users/krystofwoldrich/repos/sentry-react-native/samples/expo/node_modules/expo/android/src/main/java/expo/modules/ReactActivityDelegateWrapper.kt:139:50 No cast needed

> Task :app:createBundleReleaseJsAndAssets
Writing bundle output to: /Users/krystofwoldrich/repos/sentry-react-native/samples/expo/android/app/build/generated/assets/createBundleReleaseJsAndAssets/index.android.bundle
Writing sourcemap output to: /Users/krystofwoldrich/repos/sentry-react-native/samples/expo/android/app/build/intermediates/sourcemaps/react/release/index.android.bundle.packager.map
Copying 12 asset files
Done writing bundle output
Done writing sourcemap output

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 26s
414 actionable tasks: 22 executed, 392 up-to-date
Starting Metro Bundler
melyux commented 3 weeks ago

Can we get some eyes on this?

krystofwoldrich commented 3 weeks ago

@melyux Thank you for the message. It's currently on our backlog, but we don't have anymore details than in the original post.

Are you experiencing this locally or also in EAS?

melyux commented 3 weeks ago

EAS seems okay, I think it's local builds that are the problem.