search

getsentry / sentry-react-native

Official Sentry SDK for React Native
https://sentry.io
MIT License
1.59k stars 337 forks source link

fix(ci): Skip e2e metrics steps when the auth token is not available #4233

Closed antonis closed 2 weeks ago

antonis commented 3 weeks ago

:loudspeaker: Type of change

:scroll: Description

Checks if the auth token is accessible on a reusable workflow to fix:

Invalid workflow file: .github/workflows/e2e.yml#L27
The workflow is not valid. .github/workflows/e2e.yml (Line: 27, Col: 9): Unrecognized named-value: 'env'. Located at position 47 within expression: needs.diff_check.outputs.skip_ci != 'true' && env.SENTRY_AUTH_TOKEN != null

(example ci failure)

This solution inherits the secret to the reusable workflow that accesses it via an env variable. The output is then used in the parent workflow to skip_ci when the token is not available.

:bulb: Motivation and Context

Follow up on https://github.com/getsentry/sentry-react-native/pull/4227

:green_heart: How did you test it?

CI

:pencil: Checklist

:crystal_ball: Next steps

skip-changelog

github-actions[bot] commented 3 weeks ago

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 431.56 ms 429.95 ms -1.61 ms
Size 17.74 MiB 20.08 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ac41368cedb5f4e78bd1019e9a859ea193c3fb1a 451.47 ms 453.67 ms 2.20 ms
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 335.72 ms 355.52 ms 19.80 ms
b1e87125f5dbad623a4e4293384e68e8f702cc19 462.11 ms 465.71 ms 3.60 ms
c2a4e9b9386a596d6e84a9d857c77418388c0e5f 480.42 ms 485.60 ms 5.18 ms
0677344f8502b3ae15a3128bf239cf5571b92443 327.74 ms 337.14 ms 9.40 ms
e540498478edf6f59bd7e731809a3ea6409dcc1c 436.26 ms 433.00 ms -3.26 ms
3853f4362ec819042552ffa9ed30e8f6627e60bf 329.68 ms 346.32 ms 16.64 ms
5bb8d5f7daec6cd95071caf511b5c2d4006a55ac 431.21 ms 459.40 ms 28.19 ms
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 333.78 ms 343.94 ms 10.16 ms
70e6261eb7fdf57e3aba1f72d12c3eb518bcad99 482.65 ms 495.70 ms 13.05 ms

App size

Revision Plain With Sentry Diff
ac41368cedb5f4e78bd1019e9a859ea193c3fb1a 17.73 MiB 20.11 MiB 2.38 MiB
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 17.73 MiB 20.04 MiB 2.31 MiB
b1e87125f5dbad623a4e4293384e68e8f702cc19 17.73 MiB 19.75 MiB 2.02 MiB
c2a4e9b9386a596d6e84a9d857c77418388c0e5f 17.73 MiB 20.06 MiB 2.33 MiB
0677344f8502b3ae15a3128bf239cf5571b92443 17.73 MiB 19.81 MiB 2.07 MiB
e540498478edf6f59bd7e731809a3ea6409dcc1c 17.73 MiB 20.11 MiB 2.37 MiB
3853f4362ec819042552ffa9ed30e8f6627e60bf 17.73 MiB 19.81 MiB 2.08 MiB
5bb8d5f7daec6cd95071caf511b5c2d4006a55ac 17.73 MiB 19.93 MiB 2.20 MiB
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 17.73 MiB 19.75 MiB 2.02 MiB
70e6261eb7fdf57e3aba1f72d12c3eb518bcad99 17.73 MiB 19.94 MiB 2.21 MiB

Previous results on branch: antonis/ci-skip-metrics

Startup times

Revision Plain With Sentry Diff
066537cf33b1bfaaee50933d281bfc60ee2db589 475.69 ms 481.93 ms 6.25 ms

App size

Revision Plain With Sentry Diff
066537cf33b1bfaaee50933d281bfc60ee2db589 17.74 MiB 20.08 MiB 2.34 MiB
github-actions[bot] commented 3 weeks ago

Android (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 270.83 ms 327.09 ms 56.25 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
25343377820b65409b646b44bc8e9bc9fbb51c8c+dirty 597.14 ms 665.04 ms 67.90 ms
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 339.02 ms 408.65 ms 69.63 ms
0677344f8502b3ae15a3128bf239cf5571b92443+dirty 288.40 ms 391.44 ms 103.04 ms
d43a46b7be9152b013c84185112b1179619f8c86+dirty 417.65 ms 472.98 ms 55.33 ms
e5c9b8b6d5ce209fa4b3a77aa9de65bd590fa727+dirty 335.40 ms 360.06 ms 24.67 ms
9cab16b4cf2602d7dbadc465c56c004fe1248021+dirty 370.82 ms 416.37 ms 45.55 ms
6e8584e8f1988b33cc24c85f32711c91358905fa+dirty 383.37 ms 400.84 ms 17.47 ms
c398f670f92b4271a2da58363ef9b1d567162273+dirty 315.08 ms 345.60 ms 30.52 ms
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 363.19 ms 370.37 ms 7.18 ms
f06c879d164a5bd44945c6e000e25ce3f7c14172+dirty 361.27 ms 407.88 ms 46.61 ms

App size

Revision Plain With Sentry Diff
25343377820b65409b646b44bc8e9bc9fbb51c8c+dirty 7.15 MiB 8.11 MiB 988.68 KiB
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 7.15 MiB 8.09 MiB 964.41 KiB
0677344f8502b3ae15a3128bf239cf5571b92443+dirty 7.15 MiB 8.07 MiB 949.80 KiB
d43a46b7be9152b013c84185112b1179619f8c86+dirty 7.15 MiB 8.34 MiB 1.19 MiB
e5c9b8b6d5ce209fa4b3a77aa9de65bd590fa727+dirty 7.15 MiB 8.10 MiB 980.41 KiB
9cab16b4cf2602d7dbadc465c56c004fe1248021+dirty 7.15 MiB 8.35 MiB 1.20 MiB
6e8584e8f1988b33cc24c85f32711c91358905fa+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
c398f670f92b4271a2da58363ef9b1d567162273+dirty 7.15 MiB 8.21 MiB 1.07 MiB
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 7.15 MiB 8.04 MiB 910.84 KiB
f06c879d164a5bd44945c6e000e25ce3f7c14172+dirty 7.15 MiB 8.12 MiB 997.78 KiB

Previous results on branch: antonis/ci-skip-metrics

Startup times

Revision Plain With Sentry Diff
066537cf33b1bfaaee50933d281bfc60ee2db589+dirty 374.79 ms 403.15 ms 28.36 ms

App size

Revision Plain With Sentry Diff
066537cf33b1bfaaee50933d281bfc60ee2db589+dirty 7.15 MiB 8.35 MiB 1.20 MiB
github-actions[bot] commented 3 weeks ago

iOS (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1229.20 ms 1239.82 ms 10.61 ms
Size 2.36 MiB 3.08 MiB 737.21 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 1210.27 ms 1218.66 ms 8.39 ms
4cc5c276b8e06761211f41601792dfcbfc7dd854+dirty 1211.45 ms 1214.60 ms 3.16 ms
1c653243e2e4fd64d6c98a843b9aeccf235ba198+dirty 1235.17 ms 1235.08 ms -0.09 ms
e73d82f5e34d416eca0eb58c76599fb625345e48+dirty 1207.52 ms 1216.73 ms 9.21 ms
6e8584e8f1988b33cc24c85f32711c91358905fa+dirty 1274.50 ms 1296.82 ms 22.32 ms
9cab16b4cf2602d7dbadc465c56c004fe1248021+dirty 1237.76 ms 1234.00 ms -3.76 ms
baa882f863008502e31cca1cbab7258e929477b3+dirty 1218.00 ms 1227.04 ms 9.04 ms
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 1244.10 ms 1268.52 ms 24.42 ms
e540498478edf6f59bd7e731809a3ea6409dcc1c+dirty 1220.61 ms 1212.93 ms -7.68 ms
e5c9b8b6d5ce209fa4b3a77aa9de65bd590fa727+dirty 1258.57 ms 1267.32 ms 8.75 ms

App size

Revision Plain With Sentry Diff
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 2.36 MiB 2.83 MiB 479.25 KiB
4cc5c276b8e06761211f41601792dfcbfc7dd854+dirty 2.36 MiB 3.04 MiB 698.52 KiB
1c653243e2e4fd64d6c98a843b9aeccf235ba198+dirty 2.36 MiB 3.04 MiB 698.64 KiB
e73d82f5e34d416eca0eb58c76599fb625345e48+dirty 2.36 MiB 3.08 MiB 734.23 KiB
6e8584e8f1988b33cc24c85f32711c91358905fa+dirty 2.36 MiB 2.88 MiB 533.17 KiB
9cab16b4cf2602d7dbadc465c56c004fe1248021+dirty 2.36 MiB 3.08 MiB 737.23 KiB
baa882f863008502e31cca1cbab7258e929477b3+dirty 2.36 MiB 3.08 MiB 731.91 KiB
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 2.36 MiB 2.82 MiB 469.45 KiB
e540498478edf6f59bd7e731809a3ea6409dcc1c+dirty 2.36 MiB 3.14 MiB 793.34 KiB
e5c9b8b6d5ce209fa4b3a77aa9de65bd590fa727+dirty 2.36 MiB 2.87 MiB 520.43 KiB

Previous results on branch: antonis/ci-skip-metrics

Startup times

Revision Plain With Sentry Diff
066537cf33b1bfaaee50933d281bfc60ee2db589+dirty 1227.27 ms 1225.17 ms -2.10 ms

App size

Revision Plain With Sentry Diff
066537cf33b1bfaaee50933d281bfc60ee2db589+dirty 2.36 MiB 3.08 MiB 737.30 KiB
github-actions[bot] commented 3 weeks ago

iOS (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1232.73 ms 1226.74 ms -5.99 ms
Size 2.92 MiB 3.64 MiB 742.91 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 1268.36 ms 1273.04 ms 4.68 ms
4cc5c276b8e06761211f41601792dfcbfc7dd854+dirty 1220.43 ms 1215.13 ms -5.30 ms
1c653243e2e4fd64d6c98a843b9aeccf235ba198+dirty 1239.71 ms 1239.86 ms 0.15 ms
e73d82f5e34d416eca0eb58c76599fb625345e48+dirty 1231.20 ms 1228.81 ms -2.40 ms
6e8584e8f1988b33cc24c85f32711c91358905fa+dirty 1271.71 ms 1281.26 ms 9.55 ms
9cab16b4cf2602d7dbadc465c56c004fe1248021+dirty 1236.10 ms 1247.16 ms 11.06 ms
baa882f863008502e31cca1cbab7258e929477b3+dirty 1235.48 ms 1229.02 ms -6.46 ms
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 1245.00 ms 1257.76 ms 12.76 ms
e540498478edf6f59bd7e731809a3ea6409dcc1c+dirty 1254.92 ms 1247.21 ms -7.71 ms
e5c9b8b6d5ce209fa4b3a77aa9de65bd590fa727+dirty 1276.90 ms 1280.92 ms 4.02 ms

App size

Revision Plain With Sentry Diff
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 2.92 MiB 3.39 MiB 485.96 KiB
4cc5c276b8e06761211f41601792dfcbfc7dd854+dirty 2.92 MiB 3.61 MiB 705.47 KiB
1c653243e2e4fd64d6c98a843b9aeccf235ba198+dirty 2.92 MiB 3.61 MiB 705.56 KiB
e73d82f5e34d416eca0eb58c76599fb625345e48+dirty 2.92 MiB 3.64 MiB 740.56 KiB
6e8584e8f1988b33cc24c85f32711c91358905fa+dirty 2.92 MiB 3.44 MiB 536.52 KiB
9cab16b4cf2602d7dbadc465c56c004fe1248021+dirty 2.92 MiB 3.64 MiB 743.06 KiB
baa882f863008502e31cca1cbab7258e929477b3+dirty 2.92 MiB 3.64 MiB 738.56 KiB
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 2.92 MiB 3.38 MiB 475.74 KiB
e540498478edf6f59bd7e731809a3ea6409dcc1c+dirty 2.92 MiB 3.69 MiB 794.14 KiB
e5c9b8b6d5ce209fa4b3a77aa9de65bd590fa727+dirty 2.92 MiB 3.43 MiB 524.50 KiB

Previous results on branch: antonis/ci-skip-metrics

Startup times

Revision Plain With Sentry Diff
066537cf33b1bfaaee50933d281bfc60ee2db589+dirty 1229.47 ms 1229.75 ms 0.28 ms

App size

Revision Plain With Sentry Diff
066537cf33b1bfaaee50933d281bfc60ee2db589+dirty 2.92 MiB 3.64 MiB 742.93 KiB