search

getsentry / sentry-react-native

Official Sentry SDK for React Native
https://sentry.io
MIT License
1.59k stars 337 forks source link

fix(ios): Disable failed requests capture on iOS #4250

Closed krystofwoldrich closed 2 weeks ago

krystofwoldrich commented 2 weeks ago

:loudspeaker: Type of change

:scroll: Description

This PR disabled capture failed request on iOS.

RN JS network requests use NSURLSession as any other native request.

We capture failed requests in JS, captures from sentry-cocoa are duplicates of the JS capture.

The same does not apply to Android, as there the captured failed request are only enabled if the Sentry Android Gradle Plugin enables them.

:green_heart: How did you test it?

sample app

:pencil: Checklist

github-actions[bot] commented 2 weeks ago

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 426.48 ms 426.29 ms -0.19 ms
Size 17.74 MiB 20.08 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c639edf12520d1afee79e1ff2ba18df03ce70ec3 466.48 ms 489.57 ms 23.09 ms
575f9da84059fc88110565adb1ffc0751799bcf4 415.26 ms 422.98 ms 7.72 ms
31fcca2b37834863733f6f21677efb4b7a490aa8 391.22 ms 414.78 ms 23.56 ms
baa882f863008502e31cca1cbab7258e929477b3 354.93 ms 356.18 ms 1.25 ms
3853f4362ec819042552ffa9ed30e8f6627e60bf 329.68 ms 346.32 ms 16.64 ms
4cc5c276b8e06761211f41601792dfcbfc7dd854 460.04 ms 496.32 ms 36.28 ms
c398f670f92b4271a2da58363ef9b1d567162273 449.64 ms 461.38 ms 11.74 ms
9a3ca655542f9224aa21b4838b439748a3043b4b+dirty 326.93 ms 330.14 ms 3.21 ms
e540498478edf6f59bd7e731809a3ea6409dcc1c 436.26 ms 433.00 ms -3.26 ms
2ec71da2fbe36565c59c20f960c72fc75737275c 438.14 ms 460.46 ms 22.32 ms

App size

Revision Plain With Sentry Diff
c639edf12520d1afee79e1ff2ba18df03ce70ec3 17.74 MiB 20.08 MiB 2.34 MiB
575f9da84059fc88110565adb1ffc0751799bcf4 17.73 MiB 19.83 MiB 2.10 MiB
31fcca2b37834863733f6f21677efb4b7a490aa8 17.73 MiB 19.90 MiB 2.17 MiB
baa882f863008502e31cca1cbab7258e929477b3 17.73 MiB 20.06 MiB 2.33 MiB
3853f4362ec819042552ffa9ed30e8f6627e60bf 17.73 MiB 19.81 MiB 2.08 MiB
4cc5c276b8e06761211f41601792dfcbfc7dd854 17.73 MiB 19.95 MiB 2.21 MiB
c398f670f92b4271a2da58363ef9b1d567162273 17.73 MiB 19.94 MiB 2.21 MiB
9a3ca655542f9224aa21b4838b439748a3043b4b+dirty 17.73 MiB 20.04 MiB 2.31 MiB
e540498478edf6f59bd7e731809a3ea6409dcc1c 17.73 MiB 20.11 MiB 2.37 MiB
2ec71da2fbe36565c59c20f960c72fc75737275c 17.73 MiB 20.10 MiB 2.37 MiB

Previous results on branch: kw/fix/ios-duplicate-failed-requests

Startup times

Revision Plain With Sentry Diff
e47ca77f1c5096fa8568de26c540873ea0cbba27 460.00 ms 441.04 ms -18.96 ms
a31b5196ace5c9a6702157251ffdceab53be6ded 445.70 ms 443.53 ms -2.17 ms

App size

Revision Plain With Sentry Diff
e47ca77f1c5096fa8568de26c540873ea0cbba27 17.74 MiB 20.08 MiB 2.34 MiB
a31b5196ace5c9a6702157251ffdceab53be6ded 17.74 MiB 20.08 MiB 2.34 MiB
github-actions[bot] commented 2 weeks ago

Android (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 402.36 ms 430.08 ms 27.72 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 339.02 ms 408.65 ms 69.63 ms
86d6d2c81bc42209de70f7f3b97a1fbbde04025f+dirty 267.21 ms 325.24 ms 58.04 ms
f06c879d164a5bd44945c6e000e25ce3f7c14172+dirty 361.27 ms 407.88 ms 46.61 ms
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 371.40 ms 377.70 ms 6.31 ms
e540498478edf6f59bd7e731809a3ea6409dcc1c+dirty 408.56 ms 480.00 ms 71.44 ms
62a750bd050f26dbf2553deb01e3f453f272de2c+dirty 370.78 ms 376.73 ms 5.96 ms
2ec71da2fbe36565c59c20f960c72fc75737275c+dirty 375.64 ms 431.59 ms 55.95 ms
c639edf12520d1afee79e1ff2ba18df03ce70ec3+dirty 363.39 ms 414.78 ms 51.39 ms
acadc0f974a0c234a3d9010117b076792d14d6e8+dirty 259.04 ms 304.67 ms 45.63 ms
27ef4ee6faa6d5229b16fca7b728ca6b689ab916+dirty 296.71 ms 351.00 ms 54.29 ms

App size

Revision Plain With Sentry Diff
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 7.15 MiB 8.09 MiB 964.41 KiB
86d6d2c81bc42209de70f7f3b97a1fbbde04025f+dirty 7.15 MiB 8.09 MiB 962.69 KiB
f06c879d164a5bd44945c6e000e25ce3f7c14172+dirty 7.15 MiB 8.12 MiB 997.78 KiB
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 7.15 MiB 8.03 MiB 901.79 KiB
e540498478edf6f59bd7e731809a3ea6409dcc1c+dirty 7.15 MiB 8.38 MiB 1.23 MiB
62a750bd050f26dbf2553deb01e3f453f272de2c+dirty 7.15 MiB 8.21 MiB 1.06 MiB
2ec71da2fbe36565c59c20f960c72fc75737275c+dirty 7.15 MiB 8.38 MiB 1.23 MiB
c639edf12520d1afee79e1ff2ba18df03ce70ec3+dirty 7.15 MiB 8.35 MiB 1.20 MiB
acadc0f974a0c234a3d9010117b076792d14d6e8+dirty 7.15 MiB 8.03 MiB 903.20 KiB
27ef4ee6faa6d5229b16fca7b728ca6b689ab916+dirty 7.15 MiB 8.08 MiB 959.49 KiB

Previous results on branch: kw/fix/ios-duplicate-failed-requests

Startup times

Revision Plain With Sentry Diff
e47ca77f1c5096fa8568de26c540873ea0cbba27+dirty 378.70 ms 420.57 ms 41.87 ms

App size

Revision Plain With Sentry Diff
e47ca77f1c5096fa8568de26c540873ea0cbba27+dirty 7.15 MiB 8.35 MiB 1.20 MiB
github-actions[bot] commented 2 weeks ago

iOS (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1224.12 ms 1223.16 ms -0.96 ms
Size 2.36 MiB 3.10 MiB 752.62 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0ebca778ff7a525ecc959a1782619de87ce443b3+dirty 1220.75 ms 1222.81 ms 2.06 ms
f06c879d164a5bd44945c6e000e25ce3f7c14172+dirty 1252.64 ms 1259.66 ms 7.02 ms
8ae23a70cf23a4f7a3c54784f496e7af813b7a48+dirty 1230.02 ms 1227.62 ms -2.40 ms
d197b5c9ca10ac3f729d1b3ef805328665aa0895+dirty 1217.61 ms 1242.66 ms 25.05 ms
3ffcddd6248046202afca78f6b9af8e3f591202c+dirty 1244.47 ms 1264.14 ms 19.67 ms
457e29fc08e6edbebee646d095513d72728a5756+dirty 1253.94 ms 1269.18 ms 15.24 ms
ac41368cedb5f4e78bd1019e9a859ea193c3fb1a+dirty 1226.65 ms 1237.90 ms 11.24 ms
cdf2f334f8389e9747b61d338d9ba8945027b0d1+dirty 1227.71 ms 1233.94 ms 6.22 ms
c639edf12520d1afee79e1ff2ba18df03ce70ec3+dirty 1236.18 ms 1235.04 ms -1.14 ms
1d86dd6360b3a0207437816b46e13d91fdeaf4aa+dirty 1249.71 ms 1279.16 ms 29.45 ms

App size

Revision Plain With Sentry Diff
0ebca778ff7a525ecc959a1782619de87ce443b3+dirty 2.36 MiB 3.04 MiB 698.33 KiB
f06c879d164a5bd44945c6e000e25ce3f7c14172+dirty 2.36 MiB 2.88 MiB 530.42 KiB
8ae23a70cf23a4f7a3c54784f496e7af813b7a48+dirty 2.36 MiB 3.10 MiB 752.42 KiB
d197b5c9ca10ac3f729d1b3ef805328665aa0895+dirty 2.36 MiB 2.82 MiB 462.86 KiB
3ffcddd6248046202afca78f6b9af8e3f591202c+dirty 2.36 MiB 2.84 MiB 489.60 KiB
457e29fc08e6edbebee646d095513d72728a5756+dirty 2.36 MiB 2.87 MiB 520.67 KiB
ac41368cedb5f4e78bd1019e9a859ea193c3fb1a+dirty 2.36 MiB 3.14 MiB 793.46 KiB
cdf2f334f8389e9747b61d338d9ba8945027b0d1+dirty 2.36 MiB 3.10 MiB 751.38 KiB
c639edf12520d1afee79e1ff2ba18df03ce70ec3+dirty 2.36 MiB 3.08 MiB 736.63 KiB
1d86dd6360b3a0207437816b46e13d91fdeaf4aa+dirty 2.36 MiB 2.89 MiB 535.43 KiB

Previous results on branch: kw/fix/ios-duplicate-failed-requests

Startup times

Revision Plain With Sentry Diff
e47ca77f1c5096fa8568de26c540873ea0cbba27+dirty 1215.81 ms 1213.35 ms -2.47 ms
a31b5196ace5c9a6702157251ffdceab53be6ded+dirty 1239.50 ms 1245.15 ms 5.65 ms

App size

Revision Plain With Sentry Diff
e47ca77f1c5096fa8568de26c540873ea0cbba27+dirty 2.36 MiB 3.10 MiB 752.57 KiB
a31b5196ace5c9a6702157251ffdceab53be6ded+dirty 2.36 MiB 3.10 MiB 752.61 KiB
github-actions[bot] commented 2 weeks ago

iOS (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1231.78 ms 1229.18 ms -2.59 ms
Size 2.92 MiB 3.66 MiB 757.15 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0ebca778ff7a525ecc959a1782619de87ce443b3+dirty 1209.30 ms 1220.33 ms 11.03 ms
f06c879d164a5bd44945c6e000e25ce3f7c14172+dirty 1285.14 ms 1285.86 ms 0.72 ms
8ae23a70cf23a4f7a3c54784f496e7af813b7a48+dirty 1233.67 ms 1229.52 ms -4.15 ms
d197b5c9ca10ac3f729d1b3ef805328665aa0895+dirty 1234.80 ms 1249.20 ms 14.40 ms
3ffcddd6248046202afca78f6b9af8e3f591202c+dirty 1272.22 ms 1273.98 ms 1.76 ms
457e29fc08e6edbebee646d095513d72728a5756+dirty 1256.71 ms 1258.50 ms 1.79 ms
ac41368cedb5f4e78bd1019e9a859ea193c3fb1a+dirty 1226.69 ms 1229.96 ms 3.27 ms
cdf2f334f8389e9747b61d338d9ba8945027b0d1+dirty 1210.00 ms 1218.50 ms 8.50 ms
c639edf12520d1afee79e1ff2ba18df03ce70ec3+dirty 1223.63 ms 1227.98 ms 4.35 ms
1d86dd6360b3a0207437816b46e13d91fdeaf4aa+dirty 1289.25 ms 1293.36 ms 4.11 ms

App size

Revision Plain With Sentry Diff
0ebca778ff7a525ecc959a1782619de87ce443b3+dirty 2.92 MiB 3.61 MiB 705.12 KiB
f06c879d164a5bd44945c6e000e25ce3f7c14172+dirty 2.92 MiB 3.44 MiB 533.24 KiB
8ae23a70cf23a4f7a3c54784f496e7af813b7a48+dirty 2.92 MiB 3.66 MiB 757.67 KiB
d197b5c9ca10ac3f729d1b3ef805328665aa0895+dirty 2.92 MiB 3.37 MiB 464.41 KiB
3ffcddd6248046202afca78f6b9af8e3f591202c+dirty 2.92 MiB 3.40 MiB 494.39 KiB
457e29fc08e6edbebee646d095513d72728a5756+dirty 2.92 MiB 3.43 MiB 524.75 KiB
ac41368cedb5f4e78bd1019e9a859ea193c3fb1a+dirty 2.92 MiB 3.69 MiB 794.29 KiB
cdf2f334f8389e9747b61d338d9ba8945027b0d1+dirty 2.92 MiB 3.66 MiB 755.50 KiB
c639edf12520d1afee79e1ff2ba18df03ce70ec3+dirty 2.92 MiB 3.64 MiB 742.55 KiB
1d86dd6360b3a0207437816b46e13d91fdeaf4aa+dirty 2.92 MiB 3.44 MiB 538.27 KiB

Previous results on branch: kw/fix/ios-duplicate-failed-requests

Startup times

Revision Plain With Sentry Diff
e47ca77f1c5096fa8568de26c540873ea0cbba27+dirty 1249.24 ms 1244.80 ms -4.44 ms
a31b5196ace5c9a6702157251ffdceab53be6ded+dirty 1231.38 ms 1234.82 ms 3.43 ms

App size

Revision Plain With Sentry Diff
e47ca77f1c5096fa8568de26c540873ea0cbba27+dirty 2.92 MiB 3.66 MiB 757.29 KiB
a31b5196ace5c9a6702157251ffdceab53be6ded+dirty 2.92 MiB 3.66 MiB 757.37 KiB