search

getsentry / sentry-react-native

Official Sentry SDK for React Native
https://sentry.io
MIT License
1.59k stars 337 forks source link

fix(cocoapods): Add missing `React-RCTFabric` dependency #4314

Closed krystofwoldrich closed 5 days ago

krystofwoldrich commented 5 days ago

This PR fixes failing builds on iOS new architecture on RN version 0.70 and older.

Before RN 0.71, there was no helper to setup the cocoapods dependencies (no install_modules_dependencies).

And so libraries needed to specifi the list of deps manually.

RNSentry was missing React-RCTFabric as no Fabric components were used in the SDK.

This changed in https://github.com/getsentry/sentry-react-native/pull/4224 and was not released.

github-actions[bot] commented 5 days ago

Android (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 441.26 ms 517.67 ms 76.41 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d43a46b7be9152b013c84185112b1179619f8c86+dirty 417.65 ms 472.98 ms 55.33 ms
42973249f25bb547cf943daec67008271e93c69c+dirty 385.33 ms 435.68 ms 50.35 ms
13f280b8e8d43c2387029341d9f5e4b01e8531ad+dirty 376.13 ms 406.41 ms 30.28 ms
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 363.19 ms 370.37 ms 7.18 ms
9a3ca655542f9224aa21b4838b439748a3043b4b+dirty 344.96 ms 358.92 ms 13.96 ms
e2b64fed057d4b01cf7ad79eb19eb3c8b8002a82+dirty 258.82 ms 304.26 ms 45.44 ms
8ae23a70cf23a4f7a3c54784f496e7af813b7a48+dirty 398.10 ms 411.48 ms 13.38 ms
27ef4ee6faa6d5229b16fca7b728ca6b689ab916+dirty 296.71 ms 351.00 ms 54.29 ms
eb1e19f7a83a5f585992ae2f5e6e25251812d286+dirty 391.37 ms 418.27 ms 26.90 ms
86d6d2c81bc42209de70f7f3b97a1fbbde04025f+dirty 267.21 ms 325.24 ms 58.04 ms

App size

Revision Plain With Sentry Diff
d43a46b7be9152b013c84185112b1179619f8c86+dirty 7.15 MiB 8.34 MiB 1.19 MiB
42973249f25bb547cf943daec67008271e93c69c+dirty 7.15 MiB 8.35 MiB 1.20 MiB
13f280b8e8d43c2387029341d9f5e4b01e8531ad+dirty 7.15 MiB 8.35 MiB 1.20 MiB
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 7.15 MiB 8.04 MiB 910.84 KiB
9a3ca655542f9224aa21b4838b439748a3043b4b+dirty 7.15 MiB 8.09 MiB 962.83 KiB
e2b64fed057d4b01cf7ad79eb19eb3c8b8002a82+dirty 7.15 MiB 8.07 MiB 947.16 KiB
8ae23a70cf23a4f7a3c54784f496e7af813b7a48+dirty 7.15 MiB 8.35 MiB 1.20 MiB
27ef4ee6faa6d5229b16fca7b728ca6b689ab916+dirty 7.15 MiB 8.08 MiB 959.49 KiB
eb1e19f7a83a5f585992ae2f5e6e25251812d286+dirty 7.15 MiB 8.35 MiB 1.20 MiB
86d6d2c81bc42209de70f7f3b97a1fbbde04025f+dirty 7.15 MiB 8.09 MiB 962.69 KiB
github-actions[bot] commented 5 days ago

iOS (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1232.22 ms 1233.38 ms 1.16 ms
Size 2.92 MiB 3.67 MiB 772.39 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2b64fed057d4b01cf7ad79eb19eb3c8b8002a82+dirty 1285.78 ms 1297.56 ms 11.78 ms
4cc5c276b8e06761211f41601792dfcbfc7dd854+dirty 1220.43 ms 1215.13 ms -5.30 ms
1c653243e2e4fd64d6c98a843b9aeccf235ba198+dirty 1239.71 ms 1239.86 ms 0.15 ms
cdf2f334f8389e9747b61d338d9ba8945027b0d1+dirty 1210.00 ms 1218.50 ms 8.50 ms
e1ea4a881cf6232956e5a1e1a2e7b6a8eba730d0+dirty 1228.98 ms 1222.80 ms -6.18 ms
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 1266.52 ms 1282.55 ms 16.03 ms
ed3d77e497f60a66611b5ca8ab6c4ccf699c1256+dirty 1246.19 ms 1244.00 ms -2.19 ms
2ec71da2fbe36565c59c20f960c72fc75737275c+dirty 1230.29 ms 1239.50 ms 9.21 ms
9cd0e9f31adeacd7a9e9d72e5abd20cf25aca692+dirty 1244.61 ms 1247.43 ms 2.82 ms
0db0c729a4ac7c205a44cb4702fa7ba5b0bc03c0+dirty 1258.88 ms 1262.52 ms 3.64 ms

App size

Revision Plain With Sentry Diff
e2b64fed057d4b01cf7ad79eb19eb3c8b8002a82+dirty 2.92 MiB 3.41 MiB 499.97 KiB
4cc5c276b8e06761211f41601792dfcbfc7dd854+dirty 2.92 MiB 3.61 MiB 705.47 KiB
1c653243e2e4fd64d6c98a843b9aeccf235ba198+dirty 2.92 MiB 3.61 MiB 705.56 KiB
cdf2f334f8389e9747b61d338d9ba8945027b0d1+dirty 2.92 MiB 3.66 MiB 755.50 KiB
e1ea4a881cf6232956e5a1e1a2e7b6a8eba730d0+dirty 2.92 MiB 3.66 MiB 756.65 KiB
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 2.92 MiB 3.40 MiB 492.53 KiB
ed3d77e497f60a66611b5ca8ab6c4ccf699c1256+dirty 2.92 MiB 3.66 MiB 758.57 KiB
2ec71da2fbe36565c59c20f960c72fc75737275c+dirty 2.92 MiB 3.69 MiB 791.06 KiB
9cd0e9f31adeacd7a9e9d72e5abd20cf25aca692+dirty 2.92 MiB 3.64 MiB 741.23 KiB
0db0c729a4ac7c205a44cb4702fa7ba5b0bc03c0+dirty 2.92 MiB 3.40 MiB 492.71 KiB
github-actions[bot] commented 5 days ago

iOS (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1236.45 ms 1235.73 ms -0.72 ms
Size 2.36 MiB 3.11 MiB 759.80 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2b64fed057d4b01cf7ad79eb19eb3c8b8002a82+dirty 1232.22 ms 1255.20 ms 22.98 ms
4cc5c276b8e06761211f41601792dfcbfc7dd854+dirty 1211.45 ms 1214.60 ms 3.16 ms
1c653243e2e4fd64d6c98a843b9aeccf235ba198+dirty 1235.17 ms 1235.08 ms -0.09 ms
cdf2f334f8389e9747b61d338d9ba8945027b0d1+dirty 1227.71 ms 1233.94 ms 6.22 ms
e1ea4a881cf6232956e5a1e1a2e7b6a8eba730d0+dirty 1233.49 ms 1237.71 ms 4.22 ms
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 1223.20 ms 1236.88 ms 13.68 ms
ed3d77e497f60a66611b5ca8ab6c4ccf699c1256+dirty 1214.61 ms 1205.83 ms -8.78 ms
2ec71da2fbe36565c59c20f960c72fc75737275c+dirty 1225.85 ms 1231.57 ms 5.72 ms
9cd0e9f31adeacd7a9e9d72e5abd20cf25aca692+dirty 1224.94 ms 1239.88 ms 14.94 ms
0db0c729a4ac7c205a44cb4702fa7ba5b0bc03c0+dirty 1275.02 ms 1285.84 ms 10.82 ms

App size

Revision Plain With Sentry Diff
e2b64fed057d4b01cf7ad79eb19eb3c8b8002a82+dirty 2.36 MiB 2.85 MiB 495.80 KiB
4cc5c276b8e06761211f41601792dfcbfc7dd854+dirty 2.36 MiB 3.04 MiB 698.52 KiB
1c653243e2e4fd64d6c98a843b9aeccf235ba198+dirty 2.36 MiB 3.04 MiB 698.64 KiB
cdf2f334f8389e9747b61d338d9ba8945027b0d1+dirty 2.36 MiB 3.10 MiB 751.38 KiB
e1ea4a881cf6232956e5a1e1a2e7b6a8eba730d0+dirty 2.36 MiB 3.10 MiB 752.31 KiB
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 2.36 MiB 2.84 MiB 486.85 KiB
ed3d77e497f60a66611b5ca8ab6c4ccf699c1256+dirty 2.36 MiB 3.10 MiB 753.32 KiB
2ec71da2fbe36565c59c20f960c72fc75737275c+dirty 2.36 MiB 3.13 MiB 784.66 KiB
9cd0e9f31adeacd7a9e9d72e5abd20cf25aca692+dirty 2.36 MiB 3.08 MiB 735.56 KiB
0db0c729a4ac7c205a44cb4702fa7ba5b0bc03c0+dirty 2.36 MiB 2.84 MiB 487.01 KiB
github-actions[bot] commented 5 days ago

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 493.04 ms 475.58 ms -17.46 ms
Size 17.74 MiB 20.09 MiB 2.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8ae23a70cf23a4f7a3c54784f496e7af813b7a48 526.83 ms 513.38 ms -13.45 ms
42973249f25bb547cf943daec67008271e93c69c 536.61 ms 542.48 ms 5.87 ms
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 333.78 ms 343.94 ms 10.16 ms
c2a4e9b9386a596d6e84a9d857c77418388c0e5f 480.42 ms 485.60 ms 5.18 ms
9433f356583b99b5c970842ca1f926315bf23ba9 347.64 ms 356.22 ms 8.58 ms
9a3ca655542f9224aa21b4838b439748a3043b4b+dirty 326.93 ms 330.14 ms 3.21 ms
7bc4d758f2bdfa0bbb51d2a9119418c0f500e893 488.76 ms 473.28 ms -15.48 ms
0d3e6775185b3030074b2bca3cb796e5d265910b 422.82 ms 411.90 ms -10.92 ms
80b2ce3d0ebe86bf1196944a2036912f6670295c 385.02 ms 387.36 ms 2.34 ms
1d86dd6360b3a0207437816b46e13d91fdeaf4aa 405.14 ms 411.06 ms 5.92 ms

App size

Revision Plain With Sentry Diff
8ae23a70cf23a4f7a3c54784f496e7af813b7a48 17.74 MiB 20.07 MiB 2.34 MiB
42973249f25bb547cf943daec67008271e93c69c 17.74 MiB 20.08 MiB 2.34 MiB
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 17.73 MiB 19.75 MiB 2.02 MiB
c2a4e9b9386a596d6e84a9d857c77418388c0e5f 17.73 MiB 20.06 MiB 2.33 MiB
9433f356583b99b5c970842ca1f926315bf23ba9 17.73 MiB 19.81 MiB 2.08 MiB
9a3ca655542f9224aa21b4838b439748a3043b4b+dirty 17.73 MiB 20.04 MiB 2.31 MiB
7bc4d758f2bdfa0bbb51d2a9119418c0f500e893 17.74 MiB 20.08 MiB 2.34 MiB
0d3e6775185b3030074b2bca3cb796e5d265910b 17.74 MiB 20.07 MiB 2.34 MiB
80b2ce3d0ebe86bf1196944a2036912f6670295c 17.73 MiB 19.75 MiB 2.02 MiB
1d86dd6360b3a0207437816b46e13d91fdeaf4aa 17.73 MiB 19.86 MiB 2.12 MiB