getsentry / sentry-react-native

Official Sentry SDK for React Native
https://sentry.io
MIT License
1.59k stars 337 forks source link

fix(exports): Return `lastEventId` #4315

Closed krystofwoldrich closed 5 days ago

krystofwoldrich commented 5 days ago

Same as JS https://github.com/getsentry/sentry-javascript/issues/11951#issuecomment-2499563835

Fixes https://github.com/getsentry/sentry-react-native/issues/4311

github-actions[bot] commented 5 days ago

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 474.30 ms 477.94 ms 3.64 ms
Size 17.74 MiB 20.09 MiB 2.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d6d2c81bc42209de70f7f3b97a1fbbde04025f+dirty 332.90 ms 352.45 ms 19.55 ms
27ef4ee6faa6d5229b16fca7b728ca6b689ab916 317.40 ms 321.70 ms 4.30 ms
6e8584e8f1988b33cc24c85f32711c91358905fa 447.10 ms 474.71 ms 27.61 ms
0ebca778ff7a525ecc959a1782619de87ce443b3 414.93 ms 444.49 ms 29.56 ms
9cd0e9f31adeacd7a9e9d72e5abd20cf25aca692 449.65 ms 433.39 ms -16.26 ms
42973249f25bb547cf943daec67008271e93c69c 536.61 ms 542.48 ms 5.87 ms
d8668ce6d58c13991a0d6bfa0c9fea640a933376 452.13 ms 435.06 ms -17.07 ms
62a750bd050f26dbf2553deb01e3f453f272de2c 395.96 ms 423.36 ms 27.41 ms
9cab16b4cf2602d7dbadc465c56c004fe1248021 463.30 ms 455.06 ms -8.24 ms
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 430.68 ms 456.13 ms 25.44 ms

App size

Revision Plain With Sentry Diff
86d6d2c81bc42209de70f7f3b97a1fbbde04025f+dirty 17.73 MiB 20.04 MiB 2.31 MiB
27ef4ee6faa6d5229b16fca7b728ca6b689ab916 17.73 MiB 19.82 MiB 2.08 MiB
6e8584e8f1988b33cc24c85f32711c91358905fa 17.73 MiB 19.86 MiB 2.12 MiB
0ebca778ff7a525ecc959a1782619de87ce443b3 17.73 MiB 19.95 MiB 2.21 MiB
9cd0e9f31adeacd7a9e9d72e5abd20cf25aca692 17.74 MiB 20.08 MiB 2.34 MiB
42973249f25bb547cf943daec67008271e93c69c 17.74 MiB 20.08 MiB 2.34 MiB
d8668ce6d58c13991a0d6bfa0c9fea640a933376 17.74 MiB 20.08 MiB 2.34 MiB
62a750bd050f26dbf2553deb01e3f453f272de2c 17.73 MiB 19.93 MiB 2.20 MiB
9cab16b4cf2602d7dbadc465c56c004fe1248021 17.74 MiB 20.08 MiB 2.34 MiB
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 17.73 MiB 19.75 MiB 2.01 MiB

Previous results on branch: kw/fix-return-last-event-id-export

Startup times

Revision Plain With Sentry Diff
d005c6c9f42a54b970c06e0d9e6ab3f3a3fec077 517.77 ms 504.72 ms -13.05 ms

App size

Revision Plain With Sentry Diff
d005c6c9f42a54b970c06e0d9e6ab3f3a3fec077 17.74 MiB 20.09 MiB 2.35 MiB
github-actions[bot] commented 5 days ago

Android (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 387.39 ms 428.56 ms 41.17 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
42973249f25bb547cf943daec67008271e93c69c+dirty 385.33 ms 435.68 ms 50.35 ms
86d6d2c81bc42209de70f7f3b97a1fbbde04025f+dirty 267.21 ms 325.24 ms 58.04 ms
fe135918376819714679fec8bf2bb2e1f07ec64b+dirty 539.51 ms 597.92 ms 58.40 ms
c2a4e9b9386a596d6e84a9d857c77418388c0e5f+dirty 392.94 ms 474.55 ms 81.61 ms
61310e186d69ad44eed9571c918924161f94e7c2+dirty 463.51 ms 511.09 ms 47.57 ms
4a6664fa7140687cfa079f2d738b59b18e4ac7b7+dirty 357.02 ms 394.91 ms 37.89 ms
e1ea4a881cf6232956e5a1e1a2e7b6a8eba730d0+dirty 451.98 ms 497.58 ms 45.60 ms
5571a202e0c1fa9393e62c66ebd908444fee9c6e+dirty 359.52 ms 389.80 ms 30.28 ms
62a750bd050f26dbf2553deb01e3f453f272de2c+dirty 370.78 ms 376.73 ms 5.96 ms
a989877aa578d652ec0683764d802bb6bb6cbd2e+dirty 383.04 ms 400.92 ms 17.88 ms

App size

Revision Plain With Sentry Diff
42973249f25bb547cf943daec67008271e93c69c+dirty 7.15 MiB 8.35 MiB 1.20 MiB
86d6d2c81bc42209de70f7f3b97a1fbbde04025f+dirty 7.15 MiB 8.09 MiB 962.69 KiB
fe135918376819714679fec8bf2bb2e1f07ec64b+dirty 7.15 MiB 8.35 MiB 1.20 MiB
c2a4e9b9386a596d6e84a9d857c77418388c0e5f+dirty 7.15 MiB 8.34 MiB 1.19 MiB
61310e186d69ad44eed9571c918924161f94e7c2+dirty 7.15 MiB 8.36 MiB 1.21 MiB
4a6664fa7140687cfa079f2d738b59b18e4ac7b7+dirty 7.15 MiB 8.22 MiB 1.07 MiB
e1ea4a881cf6232956e5a1e1a2e7b6a8eba730d0+dirty 7.15 MiB 8.35 MiB 1.20 MiB
5571a202e0c1fa9393e62c66ebd908444fee9c6e+dirty 7.15 MiB 8.20 MiB 1.05 MiB
62a750bd050f26dbf2553deb01e3f453f272de2c+dirty 7.15 MiB 8.21 MiB 1.06 MiB
a989877aa578d652ec0683764d802bb6bb6cbd2e+dirty 7.15 MiB 8.35 MiB 1.20 MiB

Previous results on branch: kw/fix-return-last-event-id-export

Startup times

Revision Plain With Sentry Diff
d005c6c9f42a54b970c06e0d9e6ab3f3a3fec077+dirty 384.92 ms 410.43 ms 25.51 ms

App size

Revision Plain With Sentry Diff
d005c6c9f42a54b970c06e0d9e6ab3f3a3fec077+dirty 7.15 MiB 8.37 MiB 1.22 MiB
github-actions[bot] commented 5 days ago

iOS (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1218.79 ms 1209.15 ms -9.64 ms
Size 2.36 MiB 3.11 MiB 759.80 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
690220d8fb1cd09d2041bb25f7c812b81db1d862+dirty 1228.27 ms 1233.55 ms 5.29 ms
5a22220fafc6352a2e07e20943dda325a4cf67f5+dirty 1209.49 ms 1220.94 ms 11.45 ms
ed3d77e497f60a66611b5ca8ab6c4ccf699c1256+dirty 1214.61 ms 1205.83 ms -8.78 ms
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 1210.27 ms 1218.66 ms 8.39 ms
c398f670f92b4271a2da58363ef9b1d567162273+dirty 1219.67 ms 1225.66 ms 5.99 ms
8ae23a70cf23a4f7a3c54784f496e7af813b7a48+dirty 1230.02 ms 1227.62 ms -2.40 ms
52c056204eb6a8e4fe6e138e9307f2838242b4a6+dirty 1219.34 ms 1221.25 ms 1.91 ms
2ec71da2fbe36565c59c20f960c72fc75737275c+dirty 1225.85 ms 1231.57 ms 5.72 ms
9a3ca655542f9224aa21b4838b439748a3043b4b+dirty 1247.06 ms 1274.58 ms 27.52 ms
ac41368cedb5f4e78bd1019e9a859ea193c3fb1a+dirty 1226.65 ms 1237.90 ms 11.24 ms

App size

Revision Plain With Sentry Diff
690220d8fb1cd09d2041bb25f7c812b81db1d862+dirty 2.36 MiB 3.10 MiB 753.57 KiB
5a22220fafc6352a2e07e20943dda325a4cf67f5+dirty 2.36 MiB 2.92 MiB 570.21 KiB
ed3d77e497f60a66611b5ca8ab6c4ccf699c1256+dirty 2.36 MiB 3.10 MiB 753.32 KiB
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 2.36 MiB 2.83 MiB 479.25 KiB
c398f670f92b4271a2da58363ef9b1d567162273+dirty 2.36 MiB 3.04 MiB 696.27 KiB
8ae23a70cf23a4f7a3c54784f496e7af813b7a48+dirty 2.36 MiB 3.10 MiB 752.42 KiB
52c056204eb6a8e4fe6e138e9307f2838242b4a6+dirty 2.36 MiB 3.14 MiB 793.36 KiB
2ec71da2fbe36565c59c20f960c72fc75737275c+dirty 2.36 MiB 3.13 MiB 784.66 KiB
9a3ca655542f9224aa21b4838b439748a3043b4b+dirty 2.36 MiB 2.82 MiB 462.89 KiB
ac41368cedb5f4e78bd1019e9a859ea193c3fb1a+dirty 2.36 MiB 3.14 MiB 793.46 KiB

Previous results on branch: kw/fix-return-last-event-id-export

Startup times

Revision Plain With Sentry Diff
d005c6c9f42a54b970c06e0d9e6ab3f3a3fec077+dirty 1221.27 ms 1233.15 ms 11.88 ms

App size

Revision Plain With Sentry Diff
d005c6c9f42a54b970c06e0d9e6ab3f3a3fec077+dirty 2.36 MiB 3.10 MiB 759.77 KiB
github-actions[bot] commented 5 days ago

iOS (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1239.67 ms 1238.81 ms -0.86 ms
Size 2.92 MiB 3.67 MiB 772.44 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
690220d8fb1cd09d2041bb25f7c812b81db1d862+dirty 1227.45 ms 1221.67 ms -5.78 ms
5a22220fafc6352a2e07e20943dda325a4cf67f5+dirty 1246.18 ms 1249.61 ms 3.43 ms
ed3d77e497f60a66611b5ca8ab6c4ccf699c1256+dirty 1246.19 ms 1244.00 ms -2.19 ms
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 1268.36 ms 1273.04 ms 4.68 ms
c398f670f92b4271a2da58363ef9b1d567162273+dirty 1227.31 ms 1230.00 ms 2.69 ms
8ae23a70cf23a4f7a3c54784f496e7af813b7a48+dirty 1233.67 ms 1229.52 ms -4.15 ms
52c056204eb6a8e4fe6e138e9307f2838242b4a6+dirty 1233.94 ms 1226.29 ms -7.65 ms
2ec71da2fbe36565c59c20f960c72fc75737275c+dirty 1230.29 ms 1239.50 ms 9.21 ms
9a3ca655542f9224aa21b4838b439748a3043b4b+dirty 1276.40 ms 1279.14 ms 2.74 ms
ac41368cedb5f4e78bd1019e9a859ea193c3fb1a+dirty 1226.69 ms 1229.96 ms 3.27 ms

App size

Revision Plain With Sentry Diff
690220d8fb1cd09d2041bb25f7c812b81db1d862+dirty 2.92 MiB 3.66 MiB 758.77 KiB
5a22220fafc6352a2e07e20943dda325a4cf67f5+dirty 2.92 MiB 3.48 MiB 575.81 KiB
ed3d77e497f60a66611b5ca8ab6c4ccf699c1256+dirty 2.92 MiB 3.66 MiB 758.57 KiB
8900e1acdc5e3dcbb40938d4ba5c2abad4cc86a4+dirty 2.92 MiB 3.39 MiB 485.96 KiB
c398f670f92b4271a2da58363ef9b1d567162273+dirty 2.92 MiB 3.60 MiB 701.89 KiB
8ae23a70cf23a4f7a3c54784f496e7af813b7a48+dirty 2.92 MiB 3.66 MiB 757.67 KiB
52c056204eb6a8e4fe6e138e9307f2838242b4a6+dirty 2.92 MiB 3.69 MiB 794.15 KiB
2ec71da2fbe36565c59c20f960c72fc75737275c+dirty 2.92 MiB 3.69 MiB 791.06 KiB
9a3ca655542f9224aa21b4838b439748a3043b4b+dirty 2.92 MiB 3.37 MiB 464.32 KiB
ac41368cedb5f4e78bd1019e9a859ea193c3fb1a+dirty 2.92 MiB 3.69 MiB 794.29 KiB

Previous results on branch: kw/fix-return-last-event-id-export

Startup times

Revision Plain With Sentry Diff
d005c6c9f42a54b970c06e0d9e6ab3f3a3fec077+dirty 1245.86 ms 1251.22 ms 5.37 ms

App size

Revision Plain With Sentry Diff
d005c6c9f42a54b970c06e0d9e6ab3f3a3fec077+dirty 2.92 MiB 3.67 MiB 772.36 KiB