getsentry / sentry-react-native

Official Sentry SDK for React Native

https://sentry.io

MIT License

1.59k stars 337 forks source link

Feedback form UI #4328

Open antonis opened 2 days ago

antonis commented 2 days ago

:loudspeaker: Type of change

[ ] Bugfix
[x] New feature
[ ] Enhancement
[ ] Refactoring

:scroll: Description

TODO

Feedback Form Sample Button	Feedback Form Screen	Error Popup

:bulb: Motivation and Context

Fixes https://github.com/getsentry/sentry-react-native/issues/4302

:green_heart: How did you test it?

CI, Manual testing

:pencil: Checklist

[ ] I added tests to verify changes
[ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
[ ] I updated the docs if needed.
[ ] I updated the wizard if needed.
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

skip-changelog

github-actions[bot] commented 2 days ago

Android (legacy) Performance metrics :rocket:

	Plain	With Sentry	Diff
Startup time	464.49 ms	452.14 ms	-12.35 ms
Size	17.74 MiB	20.09 MiB	2.35 MiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI

Startup times

Revision	Plain	With Sentry	Diff
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4	461.20 ms	457.04 ms	-4.16 ms
a67330514619ea88198b049351cff84087e9e577	436.21 ms	443.04 ms	6.84 ms
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204	510.00 ms	534.31 ms	24.31 ms
b2f7f821e79458abe881a1b8f2764f8c1cd88970	436.78 ms	435.20 ms	-1.58 ms
20be313eee647899a1234e4b45895e0cdb400d08	473.12 ms	490.78 ms	17.66 ms

App size

Revision	Plain	With Sentry	Diff
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4	17.74 MiB	20.09 MiB	2.35 MiB
a67330514619ea88198b049351cff84087e9e577	17.74 MiB	20.09 MiB	2.35 MiB
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204	17.74 MiB	20.09 MiB	2.35 MiB
b2f7f821e79458abe881a1b8f2764f8c1cd88970	17.74 MiB	20.09 MiB	2.35 MiB
20be313eee647899a1234e4b45895e0cdb400d08	17.74 MiB	20.09 MiB	2.35 MiB

github-actions[bot] commented 2 days ago

Android (new) Performance metrics :rocket:

	Plain	With Sentry	Diff
Startup time	355.70 ms	386.81 ms	31.11 ms
Size	7.15 MiB	8.37 MiB	1.22 MiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI

Startup times

Revision	Plain	With Sentry	Diff
a67330514619ea88198b049351cff84087e9e577+dirty	369.77 ms	414.12 ms	44.36 ms
20be313eee647899a1234e4b45895e0cdb400d08+dirty	401.81 ms	426.80 ms	24.99 ms
b2f7f821e79458abe881a1b8f2764f8c1cd88970+dirty	377.85 ms	440.47 ms	62.61 ms
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204+dirty	393.65 ms	451.71 ms	58.06 ms
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4+dirty	344.64 ms	400.24 ms	55.59 ms

App size

Revision	Plain	With Sentry	Diff
a67330514619ea88198b049351cff84087e9e577+dirty	7.15 MiB	8.37 MiB	1.22 MiB
20be313eee647899a1234e4b45895e0cdb400d08+dirty	7.15 MiB	8.37 MiB	1.22 MiB
b2f7f821e79458abe881a1b8f2764f8c1cd88970+dirty	7.15 MiB	8.37 MiB	1.22 MiB
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204+dirty	7.15 MiB	8.37 MiB	1.22 MiB
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4+dirty	7.15 MiB	8.37 MiB	1.22 MiB

github-actions[bot] commented 2 days ago

iOS (new) Performance metrics :rocket:

	Plain	With Sentry	Diff
Startup time	1235.00 ms	1232.14 ms	-2.86 ms
Size	2.92 MiB	3.67 MiB	773.40 KiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI

Startup times

Revision	Plain	With Sentry	Diff
a67330514619ea88198b049351cff84087e9e577+dirty	1239.94 ms	1236.31 ms	-3.63 ms
20be313eee647899a1234e4b45895e0cdb400d08+dirty	1245.86 ms	1244.17 ms	-1.69 ms
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204+dirty	1228.63 ms	1222.55 ms	-6.08 ms
b2f7f821e79458abe881a1b8f2764f8c1cd88970+dirty	1242.42 ms	1234.87 ms	-7.54 ms
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4+dirty	1232.73 ms	1226.80 ms	-5.92 ms

App size

Revision	Plain	With Sentry	Diff
a67330514619ea88198b049351cff84087e9e577+dirty	2.92 MiB	3.67 MiB	772.46 KiB
20be313eee647899a1234e4b45895e0cdb400d08+dirty	2.92 MiB	3.67 MiB	772.42 KiB
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204+dirty	2.92 MiB	3.67 MiB	772.36 KiB
b2f7f821e79458abe881a1b8f2764f8c1cd88970+dirty	2.92 MiB	3.67 MiB	772.44 KiB
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4+dirty	2.92 MiB	3.67 MiB	772.35 KiB

github-actions[bot] commented 2 days ago

iOS (legacy) Performance metrics :rocket:

	Plain	With Sentry	Diff
Startup time	1232.22 ms	1236.18 ms	3.96 ms
Size	2.36 MiB	3.11 MiB	760.74 KiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI

Startup times

Revision	Plain	With Sentry	Diff
a67330514619ea88198b049351cff84087e9e577+dirty	1221.76 ms	1224.72 ms	2.97 ms
20be313eee647899a1234e4b45895e0cdb400d08+dirty	1214.98 ms	1228.34 ms	13.36 ms
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204+dirty	1229.25 ms	1228.02 ms	-1.23 ms
b2f7f821e79458abe881a1b8f2764f8c1cd88970+dirty	1224.27 ms	1232.24 ms	7.97 ms
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4+dirty	1236.22 ms	1228.98 ms	-7.25 ms

App size

Revision	Plain	With Sentry	Diff
a67330514619ea88198b049351cff84087e9e577+dirty	2.36 MiB	3.11 MiB	759.83 KiB
20be313eee647899a1234e4b45895e0cdb400d08+dirty	2.36 MiB	3.11 MiB	759.80 KiB
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204+dirty	2.36 MiB	3.10 MiB	759.77 KiB
b2f7f821e79458abe881a1b8f2764f8c1cd88970+dirty	2.36 MiB	3.10 MiB	759.76 KiB
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4+dirty	2.36 MiB	3.11 MiB	759.82 KiB