getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
926 stars 493 forks source link

Add `sidekiq-cron` patch for automatic monitoring of jobs listed in the schedule #2170

Closed sl0thentr0py closed 10 months ago

sl0thentr0py commented 10 months ago

part of #2134

codecov[bot] commented 10 months ago

Codecov Report

Merging #2170 (0699b8c) into master (a418b54) will increase coverage by 5.13%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2170 +/- ## ========================================== + Coverage 92.24% 97.37% +5.13% ========================================== Files 88 98 +10 Lines 3468 3655 +187 ========================================== + Hits 3199 3559 +360 + Misses 269 96 -173 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2170/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2170/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `98.02% <ø> (ø)` | | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2170/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `94.98% <ø> (+49.22%)` | :arrow_up: | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2170/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `95.54% <100.00%> (+1.83%)` | :arrow_up: | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2170/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `92.06% <ø> (ø)` | | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2170/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `94.36% <ø> (ø)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2170/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-sidekiq/lib/sentry-sidekiq.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXNpZGVraXEvbGliL3NlbnRyeS1zaWRla2lxLnJi) | `84.61% <100.00%> (+8.61%)` | :arrow_up: | | [sentry-sidekiq/lib/sentry/sidekiq/cron/job.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXNpZGVraXEvbGliL3NlbnRyeS9zaWRla2lxL2Nyb24vam9iLnJi) | `100.00% <100.00%> (ø)` | | ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2170/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)
lloydwatkin commented 9 months ago

We use a different file (i.e. not schedule.yml) for our sidekiq-cron setup, will this patch pull in the appropriate file.

natikgadzhi commented 9 months ago

Yep. It doesn’t care where the schedule comes from.