search

getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
926 stars 493 forks source link

Fix sentry-delayed_job: respect custom max_attempts #2177

Closed natikgadzhi closed 10 months ago

natikgadzhi commented 10 months ago

Summary

/cc @sl0thentr0py are you tired of me yet?

codecov[bot] commented 10 months ago

Codecov Report

Merging #2177 (f991b4b) into master (7793e97) will increase coverage by 0.02%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2177 +/- ## ========================================== + Coverage 97.30% 97.33% +0.02% ========================================== Files 99 99 Lines 3680 3681 +1 ========================================== + Hits 3581 3583 +2 + Misses 99 98 -1 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2177/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2177/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `98.02% <ø> (ø)` | | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2177/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `94.98% <ø> (ø)` | | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2177/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `94.50% <ø> (ø)` | | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2177/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `93.65% <ø> (+1.58%)` | :arrow_up: | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2177/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `94.44% <100.00%> (+0.07%)` | :arrow_up: | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2177/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [...entry-delayed\_job/lib/sentry/delayed\_job/plugin.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LWRlbGF5ZWRfam9iL2xpYi9zZW50cnkvZGVsYXllZF9qb2IvcGx1Z2luLnJi) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2177/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)
natikgadzhi commented 10 months ago

@st0012 yep, I've added it and didn't push it up 🤦🏼. Fixed.