search

getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
927 stars 493 forks source link

Apply bundler-cache to CI's Ruby setup #2204

Closed st0012 closed 9 months ago

st0012 commented 9 months ago

bundler-cache should automatically pick the right bundler version for us. I also applied prettier formatting to the files as I do think it improves readability.

skip-changelog

codecov[bot] commented 9 months ago

Codecov Report

Merging #2204 (d18be50) into master (bdb2c7b) will decrease coverage by 0.07%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2204 +/- ## ========================================== - Coverage 97.41% 97.34% -0.07% ========================================== Files 97 100 +3 Lines 3671 3734 +63 ========================================== + Hits 3576 3635 +59 - Misses 95 99 +4 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2204/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2204/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `98.06% <ø> (+0.03%)` | :arrow_up: | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2204/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `94.98% <ø> (ø)` | | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2204/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `94.53% <ø> (ø)` | | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2204/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `92.06% <ø> (∅)` | | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2204/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `94.44% <ø> (ø)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2204/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | [see 4 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2204/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)
st0012 commented 9 months ago

I think danger is failing for an unrelated reason:

Failing the build, there are 7 fails.
Request failed [403]: https://api.github.com/user
Response: {
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/users/users#get-the-authenticated-user"
}
Request failed [403]: https://api.github.com/user
Response: {
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/users/users#get-the-authenticated-user"
}
sl0thentr0py commented 9 months ago

danger is failing because it wants you to pin the SHA for github actions, we can ignore that