getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
933 stars 494 forks source link

Make sure sending_allowed? is respected irrespective of spotlight configuration #2231

Closed sl0thentr0py closed 8 months ago

sl0thentr0py commented 9 months ago

we need to make a difference between the 'event building' and the 'sending' so I made this more explicit.

fixes #2226

codecov[bot] commented 9 months ago

Codecov Report

Merging #2231 (497a8e0) into master (213e2ab) will decrease coverage by 33.04%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2231 +/- ## =========================================== - Coverage 97.61% 64.58% -33.04% =========================================== Files 112 111 -1 Lines 4153 4125 -28 =========================================== - Hits 4054 2664 -1390 - Misses 99 1461 +1362 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2231/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2231/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `54.29% <100.00%> (-44.04%)` | :arrow_down: | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2231/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `95.05% <ø> (ø)` | | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2231/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `94.70% <ø> (ø)` | | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2231/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `90.76% <ø> (ø)` | | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2231/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `95.60% <ø> (ø)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2231/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2231?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby/lib/sentry/client.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1YnkvbGliL3NlbnRyeS9jbGllbnQucmI=) | `39.80% <100.00%> (-60.20%)` | :arrow_down: | | [sentry-ruby/lib/sentry/configuration.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1YnkvbGliL3NlbnRyeS9jb25maWd1cmF0aW9uLnJi) | `80.00% <100.00%> (-18.80%)` | :arrow_down: | ... and [62 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2231/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)
sandstrom commented 9 months ago

Just curious, is this something that will be merged soon?

We've tried out Spotlight, but with this bug it's also caused all dev events to flow from developer machines to Sentry, with no easy way to turn it off.

Would be great for us if this could be merged!

cc @sl0thentr0py @st0012

sl0thentr0py commented 8 months ago

sorry slipped through the cracks