search

getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
933 stars 493 forks source link

Test sentry-resque without Rails, fix `constantize` issue #2248

Closed dentarg closed 8 months ago

dentarg commented 8 months ago

Fixes https://github.com/getsentry/sentry-ruby/pull/2243

codecov[bot] commented 8 months ago

Codecov Report

Merging #2248 (6405c71) into master (1d80548) will decrease coverage by 31.02%. The diff coverage is 66.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2248 +/- ## =========================================== - Coverage 97.46% 66.44% -31.02% =========================================== Files 102 101 -1 Lines 3825 3797 -28 =========================================== - Hits 3728 2523 -1205 - Misses 97 1274 +1177 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2248/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2248/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `55.63% <ø> (-42.51%)` | :arrow_down: | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2248/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `95.05% <ø> (ø)` | | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2248/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `94.70% <ø> (ø)` | | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2248/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `90.76% <66.66%> (-2.89%)` | :arrow_down: | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2248/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `95.60% <ø> (ø)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2248/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-resque/lib/sentry/resque.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJlc3F1ZS9saWIvc2VudHJ5L3Jlc3F1ZS5yYg==) | `95.00% <66.66%> (-5.00%)` | :arrow_down: | ... and [54 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2248/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)
dentarg commented 8 months ago

What do you want it to say?

st0012 commented 8 months ago

Something like:

- Fix undefined method `constantize' issue in sentry-resque ([#2248](https://github.com/getsentry/sentry-ruby/pull/2248))
dentarg commented 8 months ago

Added to the changelog ✔️