search

getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
927 stars 493 forks source link

Require `debug/prelude` in spec helper #2273

Closed st0012 closed 5 months ago

st0012 commented 5 months ago

Because the latest debug gem now requires Ruby >= 2.7, if we require debug in older Rubies, it'll require a very outdated debug lib instead.

Also, requiring debug activates the debugger even when no breakpoints are set. Requiring debug/prelude can avoid it while allowing the use of breakpoints like binding.break or debugger.

Closes #2266

skip-changelog

codecov[bot] commented 5 months ago

Codecov Report

Merging #2273 (34c1f19) into master (478c4cf) will increase coverage by 0.20%. Report is 14 commits behind head on master. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2273 +/- ## ========================================== + Coverage 97.41% 97.61% +0.20% ========================================== Files 102 112 +10 Lines 3828 4155 +327 ========================================== + Hits 3729 4056 +327 Misses 99 99 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2273/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2273/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `98.30% <ø> (+0.16%)` | :arrow_up: | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2273/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `95.05% <ø> (ø)` | | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2273/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `94.70% <ø> (ø)` | | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2273/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `92.30% <ø> (+1.53%)` | :arrow_up: | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2273/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `95.60% <ø> (ø)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2273/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | [see 20 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2273/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)