search

getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
927 stars 486 forks source link

Consolidate client report and rate limit handling with data categories #2294

Closed sl0thentr0py closed 3 months ago

sl0thentr0py commented 3 months ago

needed to clean up some logic for metrics client reports and rate limiting

codecov[bot] commented 3 months ago

Codecov Report

Merging #2294 (abe863c) into master (17959d8) will increase coverage by 0.00%. Report is 3 commits behind head on master. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2294 +/- ## ======================================= Coverage 98.69% 98.70% ======================================= Files 199 200 +1 Lines 13152 13241 +89 ======================================= + Hits 12981 13070 +89 Misses 171 171 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `99.09% <100.00%> (+<0.01%)` | :arrow_up: | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.33% <ø> (ø)` | | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `96.98% <ø> (ø)` | | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `96.76% <ø> (ø)` | | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `98.91% <ø> (ø)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby/lib/sentry/client.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294?src=pr&el=tree&filepath=sentry-ruby%2Flib%2Fsentry%2Fclient.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1YnkvbGliL3NlbnRyeS9jbGllbnQucmI=) | `100.00% <100.00%> (ø)` | | | [sentry-ruby/lib/sentry/envelope.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294?src=pr&el=tree&filepath=sentry-ruby%2Flib%2Fsentry%2Fenvelope.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1YnkvbGliL3NlbnRyeS9lbnZlbG9wZS5yYg==) | `98.33% <100.00%> (+0.37%)` | :arrow_up: | | [sentry-ruby/lib/sentry/transport.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294?src=pr&el=tree&filepath=sentry-ruby%2Flib%2Fsentry%2Ftransport.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1YnkvbGliL3NlbnRyeS90cmFuc3BvcnQucmI=) | `99.04% <100.00%> (-0.04%)` | :arrow_down: | | [...ntry-ruby/spec/sentry/client/event\_sending\_spec.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294?src=pr&el=tree&filepath=sentry-ruby%2Fspec%2Fsentry%2Fclient%2Fevent_sending_spec.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1Ynkvc3BlYy9zZW50cnkvY2xpZW50L2V2ZW50X3NlbmRpbmdfc3BlYy5yYg==) | `99.63% <100.00%> (ø)` | | | [sentry-ruby/spec/sentry/envelope\_spec.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294?src=pr&el=tree&filepath=sentry-ruby%2Fspec%2Fsentry%2Fenvelope_spec.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1Ynkvc3BlYy9zZW50cnkvZW52ZWxvcGVfc3BlYy5yYg==) | `100.00% <100.00%> (ø)` | | | [...try/transport/http\_transport\_rate\_limiting\_spec.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294?src=pr&el=tree&filepath=sentry-ruby%2Fspec%2Fsentry%2Ftransport%2Fhttp_transport_rate_limiting_spec.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1Ynkvc3BlYy9zZW50cnkvdHJhbnNwb3J0L2h0dHBfdHJhbnNwb3J0X3JhdGVfbGltaXRpbmdfc3BlYy5yYg==) | `100.00% <100.00%> (ø)` | | | [sentry-ruby/spec/sentry/transport\_spec.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2294?src=pr&el=tree&filepath=sentry-ruby%2Fspec%2Fsentry%2Ftransport_spec.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1Ynkvc3BlYy9zZW50cnkvdHJhbnNwb3J0X3NwZWMucmI=) | `100.00% <100.00%> (ø)` | |