getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
927 stars 486 forks source link

Notify users when their custom options are discarded #2303

Closed st0012 closed 3 months ago

st0012 commented 3 months ago

This is a followup on #2301

It should save users some debugging if we can tell them what options they pass are discarded and how they can fix it.

The warning is only enabled at debug level so it should not be too noisy.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.71%. Comparing base (07aaf5e) to head (e32620d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2303 +/- ## ======================================= Coverage 98.71% 98.71% ======================================= Files 202 202 Lines 13294 13301 +7 ======================================= + Hits 13123 13130 +7 Misses 171 171 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2303/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2303/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `99.09% <100.00%> (+<0.01%)` | :arrow_up: | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2303/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.37% <ø> (ø)` | | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2303/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `96.98% <ø> (ø)` | | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2303/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `96.76% <ø> (ø)` | | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2303/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `98.91% <ø> (ø)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2303/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2303?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby/lib/sentry/hub.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2303?src=pr&el=tree&filepath=sentry-ruby%2Flib%2Fsentry%2Fhub.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1YnkvbGliL3NlbnRyeS9odWIucmI=) | `99.38% <100.00%> (+<0.01%)` | :arrow_up: | | [sentry-ruby/lib/sentry/scope.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2303?src=pr&el=tree&filepath=sentry-ruby%2Flib%2Fsentry%2Fscope.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1YnkvbGliL3NlbnRyeS9zY29wZS5yYg==) | `100.00% <100.00%> (ø)` | | | [sentry-ruby/spec/sentry/hub\_spec.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2303?src=pr&el=tree&filepath=sentry-ruby%2Fspec%2Fsentry%2Fhub_spec.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1Ynkvc3BlYy9zZW50cnkvaHViX3NwZWMucmI=) | `96.86% <100.00%> (+0.03%)` | :arrow_up: | | [sentry-ruby/spec/sentry/scope\_spec.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2303?src=pr&el=tree&filepath=sentry-ruby%2Fspec%2Fsentry%2Fscope_spec.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1Ynkvc3BlYy9zZW50cnkvc2NvcGVfc3BlYy5yYg==) | `100.00% <100.00%> (ø)` | |