search

getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
927 stars 486 forks source link

Remove `config.capture_exception_frame_locals` #2306

Open st0012 opened 3 months ago

st0012 commented 3 months ago

It's been marked as deprecated for a while now and should be removed in the next major release.

Additional note: some TracePoint events can invalidate YJIT's optimization, which was a main concern of the current implementation around locals capturing. But at least until Ruby 3.3, the raise event we're using is NOT one of them.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (6.0-dev@7d86bb2). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 6.0-dev #2306 +/- ## ========================================== Coverage ? 98.66% ========================================== Files ? 201 Lines ? 13075 Branches ? 0 ========================================== Hits ? 12901 Misses ? 174 Partials ? 0 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2306/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2306/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `99.05% <0.00%> (?)` | | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2306/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.26% <0.00%> (?)` | | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2306/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `96.98% <0.00%> (?)` | | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2306/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `96.76% <0.00%> (?)` | | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2306/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `98.91% <0.00%> (?)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2306/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <0.00%> (?)` | | | [Files](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2306?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-rails/spec/dummy/test\_rails\_app/app.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2306?src=pr&el=tree&filepath=sentry-rails%2Fspec%2Fdummy%2Ftest_rails_app%2Fapp.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJhaWxzL3NwZWMvZHVtbXkvdGVzdF9yYWlsc19hcHAvYXBwLnJi) | `92.64% <100.00%> (ø)` | | | [sentry-ruby/lib/sentry/configuration.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2306?src=pr&el=tree&filepath=sentry-ruby%2Flib%2Fsentry%2Fconfiguration.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1YnkvbGliL3NlbnRyeS9jb25maWd1cmF0aW9uLnJi) | `98.75% <ø> (ø)` | | | [sentry-ruby/spec/sentry/configuration\_spec.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2306?src=pr&el=tree&filepath=sentry-ruby%2Fspec%2Fsentry%2Fconfiguration_spec.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1Ynkvc3BlYy9zZW50cnkvY29uZmlndXJhdGlvbl9zcGVjLnJi) | `100.00% <ø> (ø)` | |