search

getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
927 stars 486 forks source link

`+=` instead of `<<` #2317

Closed Vagab closed 1 month ago

Vagab commented 2 months ago

comment

Description

Describe your changes: this pr creates a copy instead of mutating the original, which fixes the issue and my company's test suite

Vagab commented 1 month ago

@sl0thentr0py I'm not sure who to tag for a review but wanted to get some eyes on this since it's blocking our upgrade to sentry 1.17

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.09%. Comparing base (7b00b25) to head (d628506).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2317 +/- ## ========================================== - Coverage 98.66% 97.09% -1.57% ========================================== Files 205 175 -30 Lines 13422 11756 -1666 ========================================== - Hits 13243 11415 -1828 - Misses 179 341 +162 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2317/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2317/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `99.03% <100.00%> (ø)` | | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2317/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `45.70% <ø> (-51.73%)` | :arrow_down: | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2317/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `96.98% <ø> (ø)` | | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2317/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `96.76% <ø> (ø)` | | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2317/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `98.91% <ø> (ø)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2317/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2317?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby/lib/sentry/test\_helper.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2317?src=pr&el=tree&filepath=sentry-ruby%2Flib%2Fsentry%2Ftest_helper.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1YnkvbGliL3NlbnRyeS90ZXN0X2hlbHBlci5yYg==) | `100.00% <100.00%> (ø)` | | ... and [43 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2317/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)