search

getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
927 stars 486 forks source link

Sample rate override ignored when set to 0 #2321

Closed azaslavsky closed 1 week ago

azaslavsky commented 1 month ago

Issue Description

At https://github.com/search?q=repo%3Agetsentry%2Fsentry-ruby+valid_sample_rate&type=code, setting sample_rate to 0 does not work.

Reproduction Steps

This was reported to us by a downstream user of the SDK.

Expected Behavior

One should be able to set the sample rate to 0.

Actual Behavior

The sample rate override is ignored.

Ruby Version

--

SDK Version

--

Integration and Its Version

No response

Sentry Config

No response

bauffman commented 1 month ago

We're having the same issue over here. We're using ruby 3.1.5 and the latest versions of the sentry gems.

sl0thentr0py commented 1 month ago

@azaslavsky @bauffman what do you mean by 'does not work'?

getsantry[bot] commented 2 weeks ago

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

bauffman commented 1 week ago

What I mean is that the system keeps sending logs to Sentry even though the sample rate is 0.0.

sl0thentr0py commented 1 week ago

@bauffman I need you to be more precise when you report a problem. 'Does not work' is not helpful for me to reproduce or analyze the issue.