getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
927 stars 486 forks source link

Don't use array for transaction names and sources on scope #2324

Closed sl0thentr0py closed 1 month ago

sl0thentr0py commented 1 month ago

closes #2257

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.66%. Comparing base (cfc2570) to head (55e87b8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2324 +/- ## ========================================== - Coverage 98.68% 98.66% -0.02% ========================================== Files 205 205 Lines 13486 13481 -5 ========================================== - Hits 13308 13301 -7 - Misses 178 180 +2 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `99.03% <100.00%> (-0.02%)` | :arrow_down: | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.41% <ø> (ø)` | | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.01% <ø> (ø)` | | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `96.79% <ø> (-0.33%)` | :arrow_down: | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `98.92% <ø> (ø)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby/lib/sentry/scope.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324?src=pr&el=tree&filepath=sentry-ruby%2Flib%2Fsentry%2Fscope.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1YnkvbGliL3NlbnRyeS9zY29wZS5yYg==) | `100.00% <100.00%> (ø)` | | | [...y-ruby/spec/sentry/rack/capture\_exceptions\_spec.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324?src=pr&el=tree&filepath=sentry-ruby%2Fspec%2Fsentry%2Frack%2Fcapture_exceptions_spec.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1Ynkvc3BlYy9zZW50cnkvcmFjay9jYXB0dXJlX2V4Y2VwdGlvbnNfc3BlYy5yYg==) | `100.00% <100.00%> (ø)` | | | [sentry-ruby/spec/sentry/scope/setters\_spec.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324?src=pr&el=tree&filepath=sentry-ruby%2Fspec%2Fsentry%2Fscope%2Fsetters_spec.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1Ynkvc3BlYy9zZW50cnkvc2NvcGUvc2V0dGVyc19zcGVjLnJi) | `97.58% <100.00%> (ø)` | | | [sentry-ruby/spec/sentry/scope\_spec.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324?src=pr&el=tree&filepath=sentry-ruby%2Fspec%2Fsentry%2Fscope_spec.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJ1Ynkvc3BlYy9zZW50cnkvc2NvcGVfc3BlYy5yYg==) | `100.00% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2324/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)