search

getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
927 stars 486 forks source link

Scope.transaction_names breaking change in 5.18.0 #2330

Closed ryandkerr closed 1 month ago

ryandkerr commented 1 month ago

Issue Description

This commit renamed scope.transaction_names to scope.transaction_name. When I update to 5.18.0 I one of my libraries breaks with the following error NoMethodError: undefined method 'transaction_names'.

Maybe transaction_names was never intended for external use, but should 5.18.0 indicate that this is a potential breaking change?

Reproduction Steps

call Sentry.get_current_scope.transaction_names

Expected Behavior

No errors

Actual Behavior

NoMethodError: undefined method 'transaction_names'

Ruby Version

3.2.3

SDK Version

5.18.0

Integration and Its Version

No response

Sentry Config

No response

sl0thentr0py commented 1 month ago

hmm, sorry for that, yea this was considered internal api, I'll clarify it in the changelog