getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
927 stars 486 forks source link

Drop `Gem::Specification`'s usage so it doesn't break bundler standalone #2335

Closed st0012 closed 1 month ago

st0012 commented 1 month ago

Fixes #2329

I also needed to bump sqlite3 because v1.6.9 doesn't run on Ruby 3.3, which is what I use in development.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.67%. Comparing base (069de02) to head (2f4e174).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2335 +/- ## ========================================== + Coverage 98.66% 98.67% +0.01% ========================================== Files 205 205 Lines 13481 13479 -2 ========================================== Hits 13301 13301 + Misses 180 178 -2 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2335/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2335/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `99.04% <ø> (+0.01%)` | :arrow_up: | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2335/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.41% <100.00%> (-0.01%)` | :arrow_down: | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2335/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.01% <ø> (ø)` | | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2335/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.11% <ø> (+0.32%)` | :arrow_up: | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2335/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `98.92% <ø> (ø)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2335/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2335?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [...b/sentry/rails/tracing/active\_record\_subscriber.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2335?src=pr&el=tree&filepath=sentry-rails%2Flib%2Fsentry%2Frails%2Ftracing%2Factive_record_subscriber.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJhaWxzL2xpYi9zZW50cnkvcmFpbHMvdHJhY2luZy9hY3RpdmVfcmVjb3JkX3N1YnNjcmliZXIucmI=) | `90.19% <100.00%> (-0.37%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2335/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)
st0012 commented 1 month ago

@sl0thentr0py working with older Rubies, especially those <= 2.5, has been increasingly frustrating. Is there any plan to ditch support for them?

sl0thentr0py commented 1 month ago

We can do it in the major, maybe I should do the major soon with dropping async and related stuff. The large hub refactor is postponed for now.

st0012 commented 1 month ago

We can do it in the major, maybe I should do the major soon with dropping async and related stuff.

FWIW, dropping a dependency/language version isn't usually considered a breaking change because in that case, the user simply won't install that version onwards.

sl0thentr0py commented 1 month ago

I've had all kinds of problems in CI etc because someone dropped language support in a minor, just cleaner to do it in a major