search

getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
927 stars 486 forks source link

Ignore Sidekiq::JobRetry::Handled exception #2337

Open karlentwistle opened 1 month ago

karlentwistle commented 1 month ago

Adds Sidekiq::JobRetry::Handled exception to default Sidekiq ignore list.

Sidekiq::JobRetry::Skip exceptions are currently ignored, however, since Sidekiq 7.3.0 shipped, I think Sidekiq::JobRetry::Handled exceptions also need to be ignored.

You can see the full diff between 7.2.4..7.3.0 and I'd particularly like to draw your attention to the changes within lib/sidekiq/job_retry.rb.

You can see in certain scenarios Sidekiq now raises Sidekiq::JobRetry::Handled (7.3.0) instead of Sidekiq::JobRetry::Skip (7.2.4).

Without this change, some customers will see the following in their Sentry Issues after upgrading to Sidekiq 7.3.0.

Screenshot 2024-07-03 at 08 27 40

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.66%. Comparing base (8e62859) to head (ebe45e4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2337 +/- ## ======================================= Coverage 98.66% 98.66% ======================================= Files 205 205 Lines 13479 13482 +3 ======================================= + Hits 13299 13302 +3 Misses 180 180 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2337/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2337/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `99.03% <ø> (ø)` | | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2337/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.41% <ø> (ø)` | | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2337/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.02% <100.00%> (+0.01%)` | :arrow_up: | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2337/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `96.79% <ø> (ø)` | | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2337/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `98.92% <ø> (ø)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2337/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2337?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-sidekiq/lib/sentry/sidekiq/configuration.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2337?src=pr&el=tree&filepath=sentry-sidekiq%2Flib%2Fsentry%2Fsidekiq%2Fconfiguration.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXNpZGVraXEvbGliL3NlbnRyeS9zaWRla2lxL2NvbmZpZ3VyYXRpb24ucmI=) | `100.00% <100.00%> (ø)` | | | [...-sidekiq/spec/sentry/sidekiq/configuration\_spec.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2337?src=pr&el=tree&filepath=sentry-sidekiq%2Fspec%2Fsentry%2Fsidekiq%2Fconfiguration_spec.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXNpZGVraXEvc3BlYy9zZW50cnkvc2lkZWtpcS9jb25maWd1cmF0aW9uX3NwZWMucmI=) | `100.00% <100.00%> (ø)` | |