Closed st0012 closed 3 weeks ago
Attention: Patch coverage is 85.71429%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 98.65%. Comparing base (
8e62859
) to head (adb69d2
).
Nice, thanks! I wonder if we should move that / 2.0
into the new helper method since we can (hopefully) trust the new container version to do the right thing? Either way looks good enough. Thank you!
ty both!
It's a new API introduced in concurrent-ruby 1.3.1, which works better in the container environment.
https://github.com/ruby-concurrency/concurrent-ruby/pull/1038
Since there are gems like sorbet-runtime that still use older versions of concurrent-ruby, we can't directly bump concurrent-ruby's requirement, but need to check if the method is available before calling it.
Big thanks to @trevorturk for proposing this idea.