getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
932 stars 493 forks source link

Patch for async-http #2427

Open ScotterC opened 3 weeks ago

ScotterC commented 3 weeks ago

Describe the idea Sentry comes bundled with getting performance spans for Net::Http and a patch for Faraday is easy to enable. Are there any plans for an async-http? Ruby async is now built into ruby and is becoming much more common place for concurrent IO operations like external API requests.

Why do you think it's beneficial to most of the users When understanding performance issues, external http calls can be a big hit. Currently if using async-http these show up as "Missing Instrumentation" in Sentry. Also, when improving IO performance, moving calls to asynchronous calls is a common tool applied which one would want to see reflected in Sentry perf dashboards.

Possible implementation

redterror commented 3 days ago

Ruby async is now built into ruby and is becoming much more common place for concurrent IO operations like external API requests.

Piling onto the sentiment here, Rails in 7.1 has a new async api for database operations (e.g. load_async and friends). I came across this issue digging into the 'Missing instrumentation' output in that context.