getsentry / sentry-ruby

Sentry SDK for Ruby
https://sentry.io/for/ruby
MIT License
938 stars 496 forks source link

Slow Rails 7.x test suite #2433

Closed solnic closed 1 month ago

solnic commented 1 month ago

Thanks for your Pull Request 🎉

Please keep these instructions in mind so we can review it more efficiently:

Other Notes

Description

Describe your changes:

github-actions[bot] commented 1 month ago
Fails
:no_entry_sign: Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Slow Rails 7.x test suite ([#2433](https://github.com/getsentry/sentry-ruby/pull/2433))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by :no_entry_sign: dangerJS against 45395cb63fd12d699aadd729e2e6f4f8048f344d

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.71%. Comparing base (d134d9e) to head (45395cb). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2433 +/- ## ======================================= Coverage 98.70% 98.71% ======================================= Files 221 221 Lines 14508 14536 +28 ======================================= + Hits 14320 14349 +29 + Misses 188 187 -1 ``` | [Components](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2433/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-ruby](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2433/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `99.02% <ø> (+<0.01%)` | :arrow_up: | | [sentry-rails](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2433/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.47% <100.00%> (+0.03%)` | :arrow_up: | | [sentry-sidekiq](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2433/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.58% <ø> (ø)` | | | [sentry-resque](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2433/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `97.11% <ø> (ø)` | | | [sentry-delayed_job](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2433/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `98.92% <ø> (ø)` | | | [sentry-opentelemetry](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2433/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | `100.00% <ø> (ø)` | | | [Files with missing lines](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2433?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry-rails/spec/dummy/test\_rails\_app/app.rb](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2433?src=pr&el=tree&filepath=sentry-rails%2Fspec%2Fdummy%2Ftest_rails_app%2Fapp.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5LXJhaWxzL3NwZWMvZHVtbXkvdGVzdF9yYWlsc19hcHAvYXBwLnJi) | `94.84% <100.00%> (+2.09%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-ruby/pull/2433/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)