search

getsentry / sentry-rust

Official Sentry SDK for Rust
https://sentry.io/
Apache License 2.0
620 stars 153 forks source link

MonitorSchedule constructor that validates crontab syntax #625

Closed szokeasaurusrex closed 1 year ago

szokeasaurusrex commented 1 year ago

I will want to use the new MonitorSchedule::from_crontab in getsentry/sentry-cli#1807

codecov[bot] commented 1 year ago

Codecov Report

Merging #625 (16ea158) into master (80e5b13) will decrease coverage by 0.08%. The diff coverage is 67.07%.

:exclamation: Current head 16ea158 differs from pull request most recent head fb65dfd. Consider uploading reports for the commit fb65dfd to get more accurate results

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   73.11%   73.03%   -0.08%     
==========================================
  Files          58       59       +1     
  Lines        6576     6658      +82     
==========================================
+ Hits         4808     4863      +55     
- Misses       1768     1795      +27
szokeasaurusrex commented 1 year ago

I noticed that CI is currently failing because I am using the function Result::is_ok_and, which was only recently made stable in Rust 1.70.0. However, it looks like CI is running in an older version (1.68.0).

Is upgrading the version of Rust we run against in CI trivial enough that we can make the change here, or do I need to rewrite my code without Result::is_ok_and?

szokeasaurusrex commented 1 year ago

Okay, I have fixed the MSRV issue.

How soon can we release a new version with these changes, since I would like to use them in https://github.com/getsentry/sentry-cli/pull/1807?