Closed semuserable closed 3 years ago
We don't assign categories for breadcrumbs from Unity.
We should set a category such as unity.logger
generic
is set by Sentry if the SDK didn't send any.
Also we can just change the docs to show a different use case for BeforeBreadcrumb
such as:
options.BeforeBreadcrumb = breadcrumb => breadcrumb.Message?.StartsWith("bad crumb") ? null : breadcrumb;
Do you want to add _hub.AddBreadcrumb
functionality into UnityLogger
?
Also, we have 2 _hub.AddBreadcrumb
calls in UnityApplicationLoggingIntegration.OnLogMessageReceived
,
one for "normal breadcrumb"
and another for "special breadcrumb"
What categories should be assigned here?
I believe the same category is fine.
We don't assign categories for breadcrumbs from Unity. It means that if user tries to use
options.BeforeBreadcrumb
based on the docs (Customize Breadcrumbs section) then he/she might find a non-expected behaviour.Not expected stuff based on current docs
categories which are
null
displayed asgeneric
on web UI, if the user tries to configure Sentry like this...... events won't be ignored on web UI, because .NET side doesn't set category to
generic
exception breadcrumbs are also ignored by
options.BeforeBreadcrumb
APIWhat needs to be done
.AddBreadcrumb
calls