Special defaults for Desktop vs Mobile vs Xyz

getsentry / sentry-unity

Development of Sentry SDK for Unity

https://docs.sentry.io/platforms/unity/

MIT License

204 stars 51 forks source link

Special defaults for Desktop vs Mobile vs Xyz #231

Open bruno-garcia opened 3 years ago

bruno-garcia commented 3 years ago

We're adding defaults that make sense on Mobile. For example #230. This features does make sense on Desktop though so we could have different defaults for Mobile vs Desktop.

[ ] On desktop environments default IsEnvironmentUser to true.

bruno-garcia commented 2 years ago

We could just flip this flag in the Sentry native Windows support configure method. So if a user opts-in to SendDefaultPii, we'll take the username of the user logged in to the machine.

In the Editor integration, we can edit the tooltip to say that this IsEnvironmentUser option only takes effect on desktop. On mobile we'll ignore what the user sets there, and force IsEnvironmentUser=false since it doesn't make sense on mobile.