search

getsentry / sentry-unity

Development of Sentry SDK for Unity
https://docs.sentry.io/platforms/unity/
MIT License
206 stars 51 forks source link

UPM package should reference dependencies instead of including them #354

Closed judithgull closed 2 years ago

judithgull commented 2 years ago

When installing the sentry package via UPM, a few dependencies are included as dlls in the package (e.g. System.Threading.Task.Extension.dll).

This leads to problems, if some of the dependencies already exist (from other packages).

In our case System.Threading.Task.Extension.dll is provided by sentry and NSubstitute.

See also forum post: https://forum.sentry.io/t/replace-dependency-dll-files-in-upm-package-with-external-dependencies/15109

bitsandfoxes commented 2 years ago

Hey @judithgull and thank you for raising this. We are aware of this issue and the potential for friction it causes. We are currently looking into a solution to this by merging our dependencies either into the SentrySDK or its own DLL (tracked here: https://github.com/getsentry/sentry-unity/issues/300)

judithgull commented 2 years ago

Great, that should work, thank you!

bruno-garcia commented 2 years ago

We wrote a blog post about how we solved this problem: https://blog.sentry.io/2022/02/24/alias-an-approach-to-net-assembly-conflict-resolution