search

getsentry / sentry-unreal

Unreal Engine
https://docs.sentry.io/platforms/unreal/
MIT License
85 stars 36 forks source link

Alert filter unreal.crashtype not respected in alert rules #256

Open rodolfoBee opened 1 year ago

rodolfoBee commented 1 year ago

Environment

SaaS (https://sentry.io/)

Version

No response

Link

No response

DSN

No response

Steps to Reproduce

1.Create a new alert with filter: The event's "unreal.crashtype" value "does not equal" "Ensure" so events that have this crash type do not trigger the alert.

  1. Send an event to the project with unreal.crashtype=Ensure.

Example alert on test org: https://dev-curumas.sentry.io/alerts/rules/notjava/4430873/details/

Expected Result

Evens that contain Unreal.crash_type=Ensure in its additional context do NOT trigger the alert.

Actual Result

The alert is triggered.

At the start I suspected it was due to Minidump processing: the Unreal context is only added after applying DIFs to the event, but from what I see in the code, any event with the context should work.

So I sent a test event with a matching context (screenshot) and it triggered the alert. Screenshot 2023-04-11 at 09 39 21

Unreal filter option was recently added here: https://github.com/getsentry/sentry/pull/44021

In any case, this issue affects a paying customer, the specific information can be found in this internal ticket (not sharing due to possible PII). In the affected user's account there are unreal events with crash_type=Ensure that triggered the alert when the rule is set to trigger only when crash type is not equal to Ensure.

getsantry[bot] commented 1 year ago

Assigning to @getsentry/support for routing, due by (sfo). ⏲️

getsantry[bot] commented 1 year ago

Routing to @getsentry/issue-experience for triage, due by (sfo). ⏲️

getsantry[bot] commented 1 year ago

Routing to @getsentry/team-mobile for triage, due by (sfo). ⏲️

brianthi commented 1 year ago

Reassigning to the mobile team since this particular filter was added by them recently.

romtsn commented 1 year ago

@bitsandfoxes would you mind looking into this, since you've implemented the feature? thanks

philipphofmann commented 1 year ago

@romtsn, @bitsandfoxes is on PTO and will be back on April 24th.

bitsandfoxes commented 1 year ago

@rodolfoBee @romtsn On it.

suyashFSG commented 1 year ago

Started using Sentry's Unreal integration recently and I have been running into exact same issue. Support forwarded me link to this issue. Would love to see this resolved so that I can properly configure Sentry alerts to only be sent for crashes and asserts and not for ensures

bitsandfoxes commented 1 year ago

@suyashFSG Thanks for reaching out. Yes, we'll revisit this.

wildlight-sam commented 5 months ago

Is there a still a plan to address this? I just ran into this issue and it's preventing me from configuring the alert setup that I want. Would love to see this fixed so that I don't have to use a subpar workaround.

bitsandfoxes commented 5 months ago

Thanks for bringing this back up. Sorry, I lost track of it and will update here accordingly.