vaind
commented
2 years ago We're currently setting this versionn in the build process, in pack.ps1, to explicitly produce packages that are compatible with multiple engine versions. My assumption when originally implementing this (based on the info found online) was that the version could be specified as partial, i.e. 5.0.x patch version would be compatible if we specify "EngineVersion" 5.0. This seems to have been wrong, based on the following code that checks the compatibility - it will fail if the version is not exactly the same as the current editor version... If it can't be parsed (or is empty), it will say it's compatible 🤔
bool FPluginManager::IsPluginCompatible(const FPlugin& Plugin)
{
if (Plugin.Descriptor.EngineVersion.Len() > 0)
{
FEngineVersion Version;
if (!FEngineVersion::Parse(Plugin.Descriptor.EngineVersion, Version))
{
UE_LOG(LogPluginManager, Warning, TEXT("Engine version string in %s could not be parsed (\"%s\")"), *Plugin.FileName, *Plugin.Descriptor.EngineVersion);
return true;
}
EVersionComparison Comparison = FEngineVersion::GetNewest(FEngineVersion::CompatibleWith(), Version, nullptr);
if (Comparison != EVersionComparison::Neither)
{
UE_LOG(LogPluginManager, Warning, TEXT("Plugin '%s' is not compatible with the current engine version (%s)"), *Plugin.Name, *Plugin.Descriptor.EngineVersion);
return false;
}
}
return true;
}This is then used only once (as of v5.0.3 source code):
for (TPair<FString, FPlugin*>& Pair : EnabledPlugins)
{
FPlugin& Plugin = *Pair.Value;
#if !IS_MONOLITHIC
// Mount the binaries directory, and check the modules are valid
if (Plugin.Descriptor.Modules.Num() > 0)
{
// Mount the binaries directory
const FString PluginBinariesPath = FPaths::Combine(*FPaths::GetPath(Plugin.FileName), TEXT("Binaries"), FPlatformProcess::GetBinariesSubdirectory());
FModuleManager::Get().AddBinariesDirectory(*PluginBinariesPath, Plugin.GetLoadedFrom() == EPluginLoadedFrom::Project);
}
// Check the declared engine version. This is a soft requirement, so allow the user to skip over it.
if (!IsPluginCompatible(Plugin) && !PromptToLoadIncompatiblePlugin(Plugin))
{
UE_LOG(LogPluginManager, Display, TEXT("Skipping load of '%s'."), *Plugin.Name);
continue;
}
#endif
Plugin.bEnabled = true;
}I'm trying to run CI where I've defined the EngineVersion with the zero at the end, e.g. 5.0.0 - let's see how that goes and whether not being compatible has any actual implications.
Maybe we should also revisit this once more and see if the EngineVersion does indeed need to be explicitly specified when uploading to the marketplace.
tustanivsky
Edstub207
imacs1
Environment
How do you use Sentry? Sentry.io
Which version of the SDK? Latest from Github Main Releases
How did you install the package? (Git-URL, Assetstore) Manually
Which version of Unreal? 5.0.1
Is this happening in Unreal (editor) or on a player like Android, iOS, Windows? TeamCity Compile job
Steps to Reproduce
Expected Result
No Warnings
Actual Result
Got a warning: LogPluginManager: Warning: Engine version string in E:/TCWorkDir/213dfa932477ea94/Project/Plugins/External/SentryUnrealPlugin/Sentry.uplugin could not be parsed ("5.0")
Any logs or screenshots