search

getsentry / sentry-webpack-plugin

Repo moved to https://github.com/getsentry/sentry-javascript-bundler-plugins. Please open any issues/PRs there.
MIT License
662 stars 116 forks source link

feat: Add function to download CLI binary #456

Closed lforst closed 9 months ago

lforst commented 9 months ago

Export downloadCliBinary to download the CLI binary so it can be installed during build-time.

lforst commented 9 months ago

Shouldn't the plugin call the the CLI's download functionality (rather than or in addition to exporting it)?

It could, however, I would rather be able to do this from the outside in order to have more elaborate logging and error handling. For instance, if the download fails, I may not want to crash and simply skip uploading.

lforst commented 9 months ago

As discussed offline, we'll for now do it this way and trial it in Next.js. If we see that it sustainably solves issues we will port this functionality to the newer plugins. If we don't have properly distributed binaries by then.