getsentry / sentry-wizard

Sentry Project Setup Wizard
MIT License
192 stars 48 forks source link

Wizard project selection "glitches" when moving the arrow up #484

Open lucas-zimerman opened 1 year ago

lucas-zimerman commented 1 year ago

Environment

-Latest version of wizard.

Steps to Reproduce

on the option of selecting the project, scroll down. then scroll up and it'll start to mark multiple projects as selected.

I also noticed that at first it didn't happen when I was using on my main display (2k resolution), but it started to break once I tried it on a 1080p display, and continued broken even after moving to the 2k monitor

Not broken video: https://github.com/getsentry/sentry-wizard/assets/8229322/a5d17894-ca6d-4c43-a5b5-b37fac4f4598 Broken video: https://github.com/getsentry/sentry-wizard/assets/8229322/2ed12990-616d-4803-8e9f-3faba42c8cd0

Expected Result

to only a single project to be marked as the selected one.

Actual Result

it seems to only happen when you move the arrow up. image

BONUS POINTS: Allow to search the project by typing the name of it, it's quite hard to find the correct project since the project names aren't sortedby their names but by the org's name

Lms24 commented 1 year ago

@lucas-zimerman I think this happens when the height of the terminal window is smaller than the "page height" of the project list. Does this bug disappear if you increase the terminal window height?

Currently, we configured clack to show 12 projects per page. Maybe we should reduce this to something between 5-8?

lucas-zimerman commented 1 year ago

It seems to glitch when the terminal window size is around 1219x399 pixels

image

Resizing to fullscreen seems to fix it (note the top is just garbage of unchanged text on the buffer so its ok)

image

My suspicious is that the Wizard requires 16 vertical character lines available, anything lower than that seems to glitch the scroll and the list

image image

By default on my VSCode I have 13 visible vertical character lines so it'll glitch on the small monitor, where on the larger monitor i have 16 vertical lines.

Lms24 commented 12 months ago

I wonder if we can detect the number of lines and adjust the sliding window/page size for the list accordingly

github-actions[bot] commented 11 months ago

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

lucas-zimerman commented 11 months ago
image

It seems to be also happening on MacOS

Lms24 commented 11 months ago

bad stalebot 😠

hmm yeah I still don't know how to fix this other than detecting the available lines or making the window smaller

Lms24 commented 11 months ago

backlogging for now but don't have time to look into it in greater detail

lucas-zimerman commented 10 months ago

this is an issue with the library itself, this could be fixed once https://github.com/natemoo-re/clack/pull/174 is merged.