search

getsentry / sentry-wizard

Sentry Project Setup Wizard
MIT License
188 stars 48 forks source link

Insert `dsn: process.env.NEXT_PUBLIC_SENTRY_DSN || 'actualdsn'` instead of just the dsn #602

Open lforst opened 3 months ago

lforst commented 3 months ago

That makes it a) easier to configure the DSN b) easier for people to understand how to parameterize the DSN properly.

lforst commented 2 months ago

When I sat down and implemented this, I realized this might be a really bad idea.

So basically we would be adding

dsn: process.env.NEXT_PUBLIC_SENTRY_DSN || "${dsn}"

That makes it very easy for people to configure the DSN via an env var, however, when they had NEXT_PUBLIC_SENTRY_DSN previously set to something other than the dsn that was inserted, they are gonna have a VERY bad time because their events won't show up where they would expect them to.

Gonna put this off.