getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.27k stars 4.21k forks source link

Support gRPC #22716

Open zs-dima opened 3 years ago

zs-dima commented 3 years ago

Could be nice to log exceptions to Sentry with gRPC, as gRPC fastest and lightweight way to communicate that quite important for mobile devices with limited internet bandwidth .

marandaneto commented 3 years ago

@zs-dima but you can, right? what's the issue? we don't log any gRPC exceptions automatically, but this won't prevent you from capturing them manually using the Sentry static class like Sentry.captureException(...)

ueman commented 3 years ago

I think the question is why Sentry does not use gRPC as a transport method (as opposed to HTTP).

marandaneto commented 3 years ago

I see, Sentry server currently does not support gRPC.

I'll transfer this issue to https://github.com/getsentry/sentry and let them handle it in there either as a feature request or wontfix.

zs-dima commented 3 years ago

@marandaneto It is gRPC transport for the .Net Core already: https://github.com/getsentry/sentry-dotnet/tree/main/samples/Sentry.Samples.AspNetCore.Grpc looks Sentry server does support gRPC

marandaneto commented 3 years ago

@zs-dima this is just a sample on how to instrument a gPRC server, not the transport that sends event over to Sentry

zs-dima commented 3 years ago

@marandaneto gRPC Server do not require any Sentry library difference, quite strange to have extra sample for this case.

github-actions[bot] commented 3 years ago

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

zs-dima commented 3 years ago

Comment