getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.14k stars 4.2k forks source link

Improve display of binary data #27990

Open DvdGiessen opened 3 years ago

DvdGiessen commented 3 years ago

Problem Statement

The display of a HTTP requests body data is not very useful when that body data is a binary format not understood by Sentry.

For reference, this is produced at the following locations in Sentry:

Solution Brainstorm

getsentry-release commented 3 years ago

Routing to @getsentry/workflow for triage. ⏲️

wedamija commented 3 years ago

@untitaker @priscilawebdev Is this something that you would handle?

untitaker commented 3 years ago

I believe so. Fwiw most sdks don't send binary bodies like that at all because those bodies are hard to strip pii from and in the general case they're not useful for debugging. I'd recommend adding an event attachment for that kind of stuff which also allows you to attach very large payloads.

We can do a better job here though I believe this would be low prio for us to work on ourselves.

MatthijsReyers commented 1 year ago

I'd like to take a shot implementing some of this, are the solutions brainstormed by @DvdGiessen sufficient?

mohammed-anwar404 commented 1 month ago

Hey just wanted to know if this issue is open, I would like to work on it as I am new to hactoberfest.

DvdGiessen commented 1 month ago

@mohammed-anwar404 I think it hasn't been addressed yet, I still see binary body data in Sentry.

getsantry[bot] commented 14 hours ago

Routing to @getsentry/product-owners-issues for triage ⏲️

jangjodi commented 13 hours ago

Hi @@mohammed-anwar404, this has not been addressed yet and the issue is still open