search

getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.06k stars 4.19k forks source link

More detail in breadcrumbs ui.click #3220

Closed soroushhakami closed 8 years ago

soroushhakami commented 8 years ago

Compared Sentrys breadcrumbs to TrackJS Telemetry Timeline, and I think Sentrys can be improved a little bit.

Sentry ui-click:

div.well.ng-scope > div.ng-scope > div > button.btn.btn-lg.btn-primary

TrackJS ui-click:

<button class="btn btn-lg btn-primary" ng-click="uploadFile()" />

It'd be really nice to be able to see all attributes on the button, such as ng-click. If possible, it'd be nice to see the text of the button aswell.

mitsuhiko commented 8 years ago

We actually started out with rendering other attributes originally but we did not really consider it useful. The only attributes currently rendered are name and indirectly class and id. Maybe it makes sense to include ng-* into the rendering.

mitsuhiko commented 8 years ago

I opened up an issue on the javascript client.

soroushhakami commented 8 years ago

Nice, thanks.

What do you think of the possibility to add the text of the button aswell? It'd make things easier especially for apps where the classnames don't reveal much.

Something along the lines of :

 div > button.btn.btn-lg.btn-primary "Purchase"
mitsuhiko commented 8 years ago

@soroushhakami ideally we move this discussion to the javascript client. The server does not care about the data being sent from the client for this purpose.

soroushhakami commented 8 years ago

My bad, will move to separate issue on the client.

mitsuhiko commented 8 years ago

Not sure if you saw, but I opened an issue here: https://github.com/getsentry/raven-js/issues/576

soroushhakami commented 8 years ago

Yeah I saw, thanks 👍 And I created another issue, for the second part of my request (they are independent): https://github.com/getsentry/raven-js/issues/577