Open Agalin opened 1 year ago
Routing to @getsentry/team-web-sdk-backend for triage. ⏲️
Routing to @getsentry/app-backend for triage. ⏲️
@Agalin feel free to submit any improvements to consistency across blaster/cluster or additional supported options for either kind of clients, for as long as they are compatible with existing prod configuration. We are not going to spend time ourselves trying to refine the redis blaster experience I think, rather we're looking into dropping redis blaster completely.
It’s strictly about Redis Cluster configuration. Currently it’s simply not possible to some clusters because only a few options can be configured.
Yeah makes sense. Either way we're happy to merge PRs that go in the direction of making this experience better, but we're not going to actively work on it right now.
On Wed, Nov 16, 2022 at 4:24 PM Agalin @.***> wrote:
It’s strictly about Redis Cluster configuration. Currently it’s simply not possible to some clusters because only a few options can be configured.
— Reply to this email directly, view it on GitHub https://github.com/getsentry/sentry/issues/40762#issuecomment-1317193824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMPRKDLBX5O2IQBL23MXLWIT4BJANCNFSM6AAAAAARTEKFIU . You are receiving this because you commented.Message ID: @.***>
Problem Statement
When configuring Redis Cluster in settings only a few selected options are supported (
startup_nodes
andreadonly_mode
+ a few more hardcoded values).Not only it differs from Redis Blaster clusters (where whole config is passed after a minor transformation to
hosts
) but also blocks some important options:Solution Brainstorm
Currently I'm using a small reimplementation of
_RedisCluster
'sfactory
method that passes a copy of the whole config excludingis_redis_cluster
(custom Sentry parameter) andhosts
as it's overwritten explicitly):It works fine but I assume there are reasons only selected list of options is supported.