getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.13k stars 4.2k forks source link

Release versioning sort does not work as expected (following semantic releases) #41944

Open mljlynch opened 1 year ago

mljlynch commented 1 year ago

Environment

SaaS (https://sentry.io/)

Version

No response

Identification

fig-food-is-good

Steps to Reproduce

  1. Open an issue (i.e. https://sentry.io/organizations/fig-food-is-good/issues/3423370412/events/?cursor=0%3A50%3A0&environment=production&project=5683151&referrer=issue-stream&sort=-release&statsPeriod=14d)
  2. Sort by version

Expected Result

3.12.4 is the latest version (not 3.9.0) image

Actual Result

3.9.0 is the latest version image

┆Issue is synchronized with this Jira Improvement by Unito

souredoutlook commented 1 year ago

Thanks @mljlynch for reporting, I paginated through the list and found where it looks like we're sorting 3.13. below 3.2.

image

I'll route this to the correct team.

getsentry-release commented 1 year ago

Routing to @getsentry/workflow for triage. ⏲️

mljlynch commented 1 year ago

Thanks @mljlynch for reporting, I paginated through the list and found where it looks like we're sorting 3.13. below 3.2.

Yes, one thing I wondered is that we have a build number appended to the release, which may be messing up some sort of isSemanticVersion parsing.

Either way, glad to help.

souredoutlook commented 1 year ago

I am not sure what the underlying query looks like, but release names are strings when not broken into their component parts for semver. And the screenshot I shared is what I would expect to see if we were sorting your releases alphabetically. I've let the team know about my assumptions.

armenzg commented 1 year ago

Thanks @mljlynch for filing! This is a real issue. I've reproduced it and added it to the backlog.

InterstellarStella commented 6 months ago

It looks like this is still an issue.

Screenshot 2024-04-18 at 12 43 00
getsantry[bot] commented 6 months ago

Routing to @getsentry/product-owners-dashboards for triage ⏲️

k-fish commented 6 months ago

@InterstellarStella you'll have to add the example dashboard for the screenshot since I tried to repro, currently it alphabetically sorts (which is why 2.10.0 will be after 2.2.0), which is where we're currently supporting sorting releases, but it looks from your screenshot that the alphabetical sort is broken even. Screenshot 2024-04-18 at 12 23 15 PM

InterstellarStella commented 6 months ago

Hey @k-fish sure thing, here's the dashboard.

k-fish commented 6 months ago

@InterstellarStella okay so it is sorting properly on the underlying release name, but you're using releases across projects (which makes sense it would sort differently. So that we don't have a huge text field in the column we alias it (and link out) to just the version. If you want the full text to show up you can use tags[release], otherwise this is still sorting alphabetically, which we don't have plans to change this at the moment.

Screenshot 2024-04-23 at 10 47 40 AM

InterstellarStella commented 6 months ago

Hi @k-fish you're right on that one. What about this dashboard, specifically the "Release Crash Table" widget? If we pick more releases and sort by release, the sorting doesn't seem right.

k-fish commented 6 months ago

@InterstellarStella in this case it's not a release column from the errors & transactions dataset, it's releases (sessions,.. etc) which I'm not as familiar with, TE team might be able to help you on that one cc: @getsentry/telemetry-experience

InterstellarStella commented 6 months ago

@getsentry/telemetry-experience any insights on this?