getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.07k stars 4.19k forks source link

[Sentry UI] Consistently Confirm Destructive Actions #45703

Open souredoutlook opened 1 year ago

souredoutlook commented 1 year ago

Problem Statement

It's currently very easy to destroy key org and project settings and auth tokens in Sentry.

For example, when copying an Auth Token from https://org-slug.sentry.io/settings/account/api/auth-tokens/, it is very easy to click Remove instead of Copy:

image

This action requires no confirmation step and may result in broken production systems.

For internal integration auth tokens (https://org-slug.sentry.io/settings/developer-settings//), the view is arranged in such a way that accidentally revoking the token instead of copying it is much more difficult:

image

Some other areas where destructive actions can be taken without a confirmation step: Organization Security and Privacy Settings (https://org-slug.sentry.io/settings/security-and-privacy/):

Project Settings (https://org-slug.sentry.io/settings/projects//):

Solution Brainstorm

In the case of user auth tokens, see the feedback from this tweet:

A little product improvement address here: Can you separate the copy and remove button a little wider? I just delete a token ran on pre-production env. @getsentry it will be very helpful. Thank you…

Other product areas such as text fields that update on change would likely benefit from a confirmation step similar to the one shown here when trying to change a project slug:

image

getsantry[bot] commented 1 year ago

Assigning to @getsentry/support for routing, due by (yyz). ⏲️

getsantry[bot] commented 1 year ago

Routing to @getsentry/core-ui for triage, due by (sfo). ⏲️