getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.18k stars 4.2k forks source link

Incorrect "Last seen" release shown in issue view #46499

Open gthb opened 1 year ago

gthb commented 1 year ago

Environment

SaaS (https://sentry.io/)

Version

No response

Link

https://grid.sentry.io/issues/3949166297/?environment=production&project=1871088&query=%22Cannot+set+properties+of+undefined+%28setting+%270%27%29%22&referrer=issue-stream&sort=freq&statsPeriod=90d&stream_index=0

DSN

No response

Steps to Reproduce

  1. Have a Sentry issue A last seen in an old release R, last month
  2. Get a new Sentry issue B that doesn't get automatically grouped with A
  3. Realize on manual inspection that B is really a recurrence of A, so manually merge them
  4. Open the issue, see that its "Last seen" entry in the right sidebar now reflects the new occurrence ("11 hours")
  5. Now notice that this "Last seen" entry claims "in release ” (that old release last month) and go “huh, somebody still has that open? 🤔”
  6. Now notice that the tags of the latest event in the issue actually show the newest release. So that “Last seen” release was incorrect (presumably from before the issues were merged)

Expected Result

I expect the “Last seen” information to show a timestamp and release ID from the same event. If one is still stale from before the issue merge (because of some “eventually consistent” fun stuff underneath), then both should be, because that's less misleading.

Actual Result

image

getsantry[bot] commented 1 year ago

Assigning to @getsentry/support for routing, due by (sfo). ⏲️

getsantry[bot] commented 1 year ago

Routing to @getsentry/workflow for triage, due by (sfo). ⏲️

scttcper commented 1 year ago

Thanks for reporting this really clearly, I've added this to the teams backlog. There's a few funky things that happen when merging issues.

brianthi commented 1 year ago

Hi @gthb, we're thinking about how to improve our grouping logic so that manual merges become less necessary. Could you share with us what data in the issue you used which gave you confidence that one issue was a recurrence of another?

gthb commented 1 year ago

Could you share with us what data in the issue you used which gave you confidence that one issue was a recurrence of another?

It was the tip of the stack trace, combined with my knowledge that differences in stack frames further up do not matter in this case, that is, they do not make for separately addressable issues. Kinda doubt that there's a generalizable way to determine that without domain knowledge, but who knows, you are the wizzes with respect to that :)

etienne-bondot commented 7 months ago

Hi, I had a similar issue seting up a new sentry integration. Publishing multiple releases and trigerring the same error (from the example of the documentation). I can see the error handled by Sentry on each release:

image

But on the issue report, the "Last seen" field is still set to the first occurence (release v0.0.22).

image

Any news on this issue?

I'm using NextJs deploying on Vercel with @sentry/nextjs v7.103.0.

It's not critical on my side, I just want to share this example and follow the discussion.

EDIT: After some times, the last seen value is OK. May be some cache after all.

getsantry[bot] commented 7 months ago

Routing to @getsentry/product-owners-issues for triage ⏲️