getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.04k stars 4.19k forks source link

Sentry tries to unminify code that isn't minified #54259

Open SliceCraft opened 1 year ago

SliceCraft commented 1 year ago

Self-Hosted Version

21.7.2

CPU Architecture

x86_64

Docker Version

20.10.21

Docker Compose Version

2.12.2

Steps to Reproduce

  1. Setup a nodejs project on Sentry
  2. Copy the example code
  3. Run the example code
  4. Sentry gives an error message saying that the code can't be unminified due to missing sourcemaps

Expected Result

I would expect the issues to appear in the dashboard without any problems and for it to display the code where the error occured.

Actual Result

image image I did attempt to make a question on stackoverflow in the hopes that someone would know if I'm doing anything wrong. Unfortunately nothing came out of that but there is some more information about the problem I'm having there. https://stackoverflow.com/questions/76716572/sentry-tries-to-unminify-code-that-isnt-minified-and-shows-an-invalid-absolute

This problem initially happened on 23.4.0 after which I tried updating to 23.6.2 and later to 23.7.0 which both did not resolve the issue, yesterday I tried updating to 23.7.1 to see if that would help but it also did not resolve the issue. After updating to 23.7.1 the error messages for some issues that were created before the update did go away or changed to "It looks like you're creating, but not uploading your source maps. Read our docs for troubleshooting help.", however I am still not creating any source maps because the code isn't being minified. Some of the already existing issues didn't change though. When new issues are created with commonjs it no longer causes any problems but when using es6 imports the dashboard still reports "Invalid Absolute Path URL" errors.

Since I saw that after I updated to 23.7.1 a new update (23.7.2) was released I decided to update to see if this version would fix any problems. It didn't fix any problems but did add this extra message which shouldn't appear.

docker-compose-logs.txt install-logs.txt

Event ID

No response

getsantry[bot] commented 1 year ago

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] commented 1 year ago

Routing to @getsentry/product-owners-issues for triage ⏲️

roggenkemper commented 1 year ago

Thanks for the thorough message! I'm working on getting this fixed and will keep you updated!

roggenkemper commented 1 year ago

Hi! I merged a change that hopefully addresses this, would you mind letting me know if you are still seeing this problem?

SliceCraft commented 1 year ago

When using commonjs the error doesn't show up anymore.

However when using the es6 import I still can't see the stack trace and it still shows a notification about uploading sourcemaps. image

roggenkemper commented 1 year ago

do you know what version of sentry you are running when you see this latest notification? would you mind downloading the JSON for this event and email it to me at richard.roggenkemper@sentry.io so i could take a closer look at it?

SliceCraft commented 1 year ago

I did send an email with the subject Information about github issue 54259 on the 16th of august. Have you been able to take a closer look?

roggenkemper commented 1 year ago

Responded to your email!

roggenkemper commented 1 year ago

Hi! Sorry for the delayed response. We have decided to remove these alerts for now as we weren't 100% confident in when they were showing up. Thank you for bringing that problem to our attention. If you are still having any problems, please let us know Richard

On Wed, Sep 6, 2023 at 4:05 PM Slice @.***> wrote:

I did send an email with the subject Information about github issue 54259 on the 16th of august. Have you been able to take a closer look?

— Reply to this email directly, view it on GitHub https://github.com/getsentry/sentry/issues/54259#issuecomment-1709237762, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALETGCUB5K3EBKDJJRSJ6YLXZD6UJANCNFSM6AAAAAA3E32BPI . You are receiving this because you were assigned.Message ID: @.***>

-- https://www.notion.so/sentry/Email-Signature-specs-7d543ef317d742df93b2bb211b5167af#47cba7e80fb9483bb26df120e0b20868Richard Roggenkemper Software Engineer, Growth he/him/his sentry.io

https://sentryio-assets.storage.googleapis.com/img/email-signature/sentry-logo-bar.png https://sentryio-assets.storage.googleapis.com/img/email-signature/sentry-logo-bar.png

SliceCraft commented 1 year ago

Part of the reason for me making this issue was because there was no code included with errors caused when using node with es6. When importing the sentry javascript sdk by using require (commonjs) it would show part of the code in the dashboard. This is no longer possible since the sdk doesn't use commonjs anymore but I do still have an issue in my sentry dashboard from when this was possible. image

When importing the javascript sdk with es6 imports it will still show the stack trace but without showing any code. image

I would expect it to also show code when importing sentry with es6.

malwilley commented 1 year ago

@SliceCraft you should try uploading source maps (https://docs.sentry.io/platforms/node/sourcemaps/). The original error message was a bit confusing since it mentioned minification, which you are not doing, but using es6 imports probably requires source maps for Sentry to identify your source code correctly.