getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.11k stars 4.2k forks source link

Invalid invite link in Email #59245

Open DartCZ opened 1 year ago

DartCZ commented 1 year ago

Self-Hosted Version

23.10.1

CPU Architecture

x86_64

Docker Version

20.10.5+dfsg1, build 55c4c88

Docker Compose Version

2.21.0

Steps to Reproduce

In Inkognito tab Request to join, enter email In the tab with administration account approve new member. Copy link from email and open in inkognito tab, user receive invalid link with message "This organization invite link is no longer valid."

Workaround: Edit invite link https://sentry.host.com/accept/{userId}/{hash}/ To https://sentry.host.com/accept/{organizationSlug}/{userId}/{hash}/

Expected Result

User receive valid invite link in email.

Actual Result

User received invalid invite link in email.

Event ID

No response

hubertdeng123 commented 1 year ago

Thanks for reporting this to us. I've dug a bit into this and it seems like something with sentry-accept-invite is going wrong. I'll transfer it over to another team that hopefully has more context here

https://github.com/getsentry/sentry/blob/4c72698baf6135ab077158a6099a65090315799a/src/sentry/web/urls.py#L466

getsantry[bot] commented 1 year ago

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] commented 1 year ago

Routing to @getsentry/product-owners-sign-in for triage ⏲️

sentaur-athena commented 1 year ago

The link is correct here. The invite link is only valid if invite is not approved, after getting approved it won't work.