getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.13k stars 4.2k forks source link

Changing Jira Server Integration Settings does not create audit events #61132

Open Tomanow opened 11 months ago

Tomanow commented 11 months ago

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Open Jira Server integration settings
  2. Toggle any of the settings like "Sync Sentry Assignment to Jira Server"
  3. Check audit log for event like integration.edit

Expected Result

Audit event of user that modified settings

Actual Result

No audit events and no logs (verified with Sentry support).

Product Area

Settings - Integrations

Link

/settings/integrations/jira_server/183356/

DSN

No response

Version

No response

getsantry[bot] commented 11 months ago

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] commented 11 months ago

Routing to @getsentry/product-owners-settings-integrations for triage ⏲️

lobsterkatie commented 11 months ago

Hi, @Tomanow. Thanks for reporting this.

When you make the change, do you see a request to our API to send the change? If so, what's getting sent and to which endpoint? Is it successful?

Tomanow commented 11 months ago

I'm making these changes from the Sentry UI. I see an event in browser console for integrations.details_viewed, but none for the actual settings change.

Screenshot 2023-12-07 at 10 14 41 AM
// POST https://sentry.io/api/0/organizations/REDACTED/integrations/183356/
{"sync_reverse_assignment":false}

// POST https://reload.getsentry.net/metric/
[
  {
    "user_id": "2635668",
    "url": "https://REDACTED.sentry.io/settings/integrations/jira_server/183356/",
    "path": "/settings/integrations/jira_server/183356/",
    "referrer": "https://accounts.google.com/",
    "document_referrer": "https://accounts.google.com/",
    "title": "Jira Server — Sentry",
    "sent_at": "1701962141943",
    "metric_name": "app.api.request-success",
    "value": 3791.300000011921,
    "tags": {
      "status": 200,
      "release": "frontend@ff13ccc37b3671892c0409b66d903adc53abe1e1"
    }
  }
]

// POST https://reload.getsentry.net/event/
{
  "user_id": 2635668,
  "url": "https://REDACTED.sentry.io/settings/integrations/jira_server/183356/",
  "path": "/settings/integrations/jira_server/183356/",
  "referrer": "https://accounts.google.com/",
  "document_referrer": "https://accounts.google.com/",
  "title": "Jira Server — Sentry",
  "sent_at": "1701962244851",
  "event_name": "integrations.details_viewed",
  "org_id": 4504991346720768,
  "allow_no_schema": true,
  "parameterized_path": "settings.integrations.:provider_key.:integration_id",
  "integration": "jira_server",
  "integration_type": "first_party",
  "analytics_session_id": "142255a9-8ae6-6454-3f3a-d34ced675ca9",
  "previous_referrer": "issue-stream",
  "role": "owner",
  "plan": "am2_business_ent_auf",
  "can_trial": false,
  "is_trial": false
}
brianthi commented 11 months ago

Thanks for raising this to us @Tomanow. There are other places in our app where we're looking to add auditing to as well, and this is an area I believe that need it. I'll add this to a running list we've got going and when we can prioritize it, we'll update this ticket.