getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.01k stars 4.19k forks source link

Unable to load large number of tags on discover view #61999

Open eddielopezfd opened 10 months ago

eddielopezfd commented 10 months ago

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

Expected Result

Able to load page with tags

Actual Result

some tags are unable to load on certain events within discover

Product Area

Discover

Link

https://fanduel-sb.sentry.io/discover/sportsbook-v2:c03cf6b3464e4b38a7abc002699ef073/?field=title&field=release&field=environment&field=user.display&field=timestamp&name=EXC_BREAKPOINT%3A+Exception+6%2C+Code+13924416%2C+Subcode+8&project=5644496&query=issue%3ASPORTSBOOK-V2-EJF&sort=-timestamp&statsPeriod=90d&yAxis=count%28%29

DSN

No response

Version

No response

┆Issue is synchronized with this Jira Improvement by Unito

getsantry[bot] commented 10 months ago

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] commented 10 months ago

Routing to @getsentry/product-owners-discover for triage ⏲️

gggritso commented 9 months ago

@eddielopezfd thanks for raising this! Is this a consistent issue, do you get the error every time, or has it gone away recently?

eddielopezfd commented 5 months ago

Hi @gggritso, Our team is constantly running into an 'Unable to load tag' error when working with the issue discover page. The tags won't load, and we see failed network requests. This makes it difficult to add tags to filter logs, hindering our troubleshooting efforts.

Network Errors

tag-network-error-2

tag-network-error-1

{
    "detail": "\nQuery timeout. Please try again. If the problem persists try a smaller date range or fewer projects. Also consider a\nfilter on the transaction field if you're filtering performance data.\n"
}

Unable to load tags

unable-to-load-tags

gggritso commented 5 months ago

@eddielopezfd hiya, thanks for raising this again. I'm going to take a look at this over the next few days and get back to you!

eddielopezfd commented 5 months ago

@eddielopezfd hiya, thanks for raising this again. I'm going to take a look at this over the next few days and get back to you!

Thank you

gggritso commented 5 months ago

@eddielopezfd I took a look! I have some questions and some suggestions. First, the questions:

  1. Where are you most hindered by this? Are you relying on tag autocomplete, and they're not showing up? Is the "Unable to load tags" message annoying? Something else?
  2. How are you using your tags (I see you tag experiments and feature flags, which is common)? Do you need to be able to search by these tags, or are you only looking at them when looking at a specific exception?
eddielopezfd commented 5 months ago
  1. Where are you most hindered by this? Are you relying on tag autocomplete, and they're not showing up? Is the "Unable to load tags" message annoying? Something else?
  1. How are you using your tags (I see you tag experiments and feature flags, which is common)? Do you need to be able to search by these tags, or are you only looking at them when looking at a specific exception?

Screenshot 2024-05-17 at 9 49 27 AM

gggritso commented 5 months ago

@eddielopezfd understood, thanks for sharing that!

First of all, I'm going to try to speed up the tag loading. Also, I think that maybe you should be able to type in whatever column you want, even if that tag wasn't loaded. I'll take that up with the product team.

Secondly, workarounds! You can force a tag through the URL. e.g., the URL https://fanduel-sb.sentry.io/discover/homepage/?field=tags[region]&field=count()&query=&sort=-count&statsPeriod=24h&yAxis=count() will create a table of issue counts by the region tag. This should work regardless of tag loading. You can substitute the tag you want in the right part of the URL to get the right query running. That'll at least unblock you when doing investigations.

Thirdly, an overall suggestion. Loading tags gets slower depending on how many events and unique tags a project has. If a project has a lot of events and a lot of unique tags (say, in the many 100s of tags), tag loading can get really slow. This degrades the product experience (tag loading, tag autocomplete, tags breakdown pages, etc.)

You could probably improve your overall experience with a few approaches:

  1. Move any metadata that you don't need to search on from a tag to a context. A context can be a good place to put feature flags, experiments, or anything else that has a lot of data. You won't be able to search for this, but it'll show up on the Issue Details page, so it's handy while debugging. Contexts also have much looser restrictions on keys, values, and the overall size. They're a good fit for unstructured data.
  2. If that's not possible, you can try being more restrictive about which tags are added. e.g., only add tags for the most interesting cases, only add a tag if it's relevant, only add a boolean tag if the value is true, etc.
eddielopezfd commented 6 days ago

Hi @gggritso , has there been any movement on getting this prioritized?

gggritso commented 4 days ago

@eddielopezfd not yet, sorry! I'll raise this with the team this week