Already unminified frames show "Unminify Code" button

getsentry / sentry

Developer-first error tracking and performance monitoring

https://sentry.io

Other

39.08k stars 4.2k forks source link

Already unminified frames show "Unminify Code" button #67148

Open thinkocapo opened 7 months ago

thinkocapo commented 7 months ago

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

React Native. Message me for private sdk code and event link.

Expected Result

should not say Unminify Code

Actual Result

and (blurred out the code) ^ see it shows code, it's deminified.

Product Area

Profiling

Link

No response

DSN

No response

Version

No response

getsantry[bot] commented 7 months ago

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] commented 7 months ago

Routing to @getsentry/product-owners-profiling for triage ⏲️

getsantry[bot] commented 7 months ago

Routing to @getsentry/product-owners-issues-source-maps for triage ⏲️

lforst commented 7 months ago

Thanks for reporting! This is on my radar and backlog.

krystofwoldrich commented 7 months ago

I've noticed this happens when the unminified source is *.js file.

The Debug IDs Modal shows that it could not find a source map for the given file, but the stack trace was symbolicated in the case of Release Artifacts.

lforst commented 7 months ago

The problem with stack frames that are unminified to JS files is that we cannot know whether they were successfully source mapped or not. We need to flesh out the logic a bit more.