getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
36.96k stars 3.97k forks source link

Fix Issue update flow to prevent redoing actions #69250

Open ykamo001 opened 1 week ago

ykamo001 commented 1 week ago

When Issues are attempted to be updated, we should do a no-op if the action does not actually change anything. Look into update_group function and entry path where we call update_groups from sentry.api.helpers.group_index. This function currently allows a resolved issue to be resolved again, or an archived issue to be archived again, resulting in multiple of the same activity to be created in the activity model.

Screenshot 2024-04-09 at 11 39 51 AM

getsantry[bot] commented 1 week ago

Routing to @getsentry/product-owners-issues for triage ⏲️

mrduncan commented 1 week ago

Added to the Core Product rotational backlog, we'll look into potentially resolving this as a part of upcoming work to the issue stream since it also seems to be one of the places allowing duplicate resolutions.

ykamo001 commented 1 week ago

Related to: https://github.com/getsentry/sentry/issues/69252