getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
36.96k stars 3.97k forks source link

feat(chartcuterie): endpoint regression backend #69279

Closed sentaur-athena closed 1 day ago

sentaur-athena commented 1 week ago

The goal of this PR is that add a chartcuterie request on the path of sending slack notification to add image to endpoint regression issue alerts. If image generation fails we still send the message, just without image.

github-actions[bot] commented 1 week ago

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 89.77273% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 79.84%. Comparing base (20c86f5) to head (a1b5e40). Report is 164 commits behind head on master.

:exclamation: Current head a1b5e40 differs from pull request most recent head 5450942. Consider uploading reports for the commit 5450942 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #69279 +/- ## ========================================== + Coverage 77.10% 79.84% +2.73% ========================================== Files 6476 6485 +9 Lines 287788 288434 +646 Branches 49597 49689 +92 ========================================== + Hits 221910 230298 +8388 + Misses 65486 57744 -7742 Partials 392 392 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/69279?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [...try/api/endpoints/organization\_events\_trends\_v2.py](https://app.codecov.io/gh/getsentry/sentry/pull/69279?src=pr&el=tree&filepath=src%2Fsentry%2Fapi%2Fendpoints%2Forganization_events_trends_v2.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9hcGkvZW5kcG9pbnRzL29yZ2FuaXphdGlvbl9ldmVudHNfdHJlbmRzX3YyLnB5) | `92.10% <100.00%> (-0.21%)` | :arrow_down: | | [src/sentry/conf/server.py](https://app.codecov.io/gh/getsentry/sentry/pull/69279?src=pr&el=tree&filepath=src%2Fsentry%2Fconf%2Fserver.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9jb25mL3NlcnZlci5weQ==) | `89.18% <ø> (ø)` | | | [src/sentry/features/temporary.py](https://app.codecov.io/gh/getsentry/sentry/pull/69279?src=pr&el=tree&filepath=src%2Fsentry%2Ffeatures%2Ftemporary.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9mZWF0dXJlcy90ZW1wb3JhcnkucHk=) | `100.00% <100.00%> (ø)` | | | [...sentry/utils/performance\_issues/detectors/utils.py](https://app.codecov.io/gh/getsentry/sentry/pull/69279?src=pr&el=tree&filepath=src%2Fsentry%2Futils%2Fperformance_issues%2Fdetectors%2Futils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS91dGlscy9wZXJmb3JtYW5jZV9pc3N1ZXMvZGV0ZWN0b3JzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | | | [...entry/integrations/slack/message\_builder/issues.py](https://app.codecov.io/gh/getsentry/sentry/pull/69279?src=pr&el=tree&filepath=src%2Fsentry%2Fintegrations%2Fslack%2Fmessage_builder%2Fissues.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9pbnRlZ3JhdGlvbnMvc2xhY2svbWVzc2FnZV9idWlsZGVyL2lzc3Vlcy5weQ==) | `89.70% <83.33%> (+14.15%)` | :arrow_up: | | [...y/integrations/slack/message\_builder/time\_utils.py](https://app.codecov.io/gh/getsentry/sentry/pull/69279?src=pr&el=tree&filepath=src%2Fsentry%2Fintegrations%2Fslack%2Fmessage_builder%2Ftime_utils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9pbnRlZ3JhdGlvbnMvc2xhY2svbWVzc2FnZV9idWlsZGVyL3RpbWVfdXRpbHMucHk=) | `91.42% <91.42%> (ø)` | | | [...tions/slack/message\_builder/image\_block\_builder.py](https://app.codecov.io/gh/getsentry/sentry/pull/69279?src=pr&el=tree&filepath=src%2Fsentry%2Fintegrations%2Fslack%2Fmessage_builder%2Fimage_block_builder.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9pbnRlZ3JhdGlvbnMvc2xhY2svbWVzc2FnZV9idWlsZGVyL2ltYWdlX2Jsb2NrX2J1aWxkZXIucHk=) | `87.50% <87.50%> (ø)` | | ... and [638 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/69279/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)
sentry-io[bot] commented 1 day ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎