Closed ceorourke closed 3 weeks ago
@saponifi3d idk why I can't reply to your comment about the branch, I'd prefer to find out now rather than later when we have a lot more going on if I somehow fucked this up
Attention: Patch coverage is 72.41379%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 79.64%. Comparing base (
6c0b883
) to head (b3304fb
). Report is 1 commits behind head on master.:exclamation: Current head b3304fb differs from pull request most recent head 56120ee. Consider uploading reports for the commit 56120ee to get more accurate results
So we've now added comparison type and interval to the data fixtures to determine our rates?
a few nit comments
no, nothing is added. I just moved stuff around
This pull request was deployed and Sentry observed the following issues:
sentry.tasks.post_process.post_process_group
View Issuesentry.tasks.post_process.post_process_group
View Issuesentry.tasks.post_process.post_process_group
View Issuesentry.tasks.post_process.post_process_group
View Issuesentry.tasks.post_process.post_process_group
View IssueDid you find this useful? React with a 👍 or 👎
This pull request was deployed and Sentry observed the following issues:
sentry.tasks.post_process.post_process_group
View IssueDid you find this useful? React with a 👍 or 👎
The
apply_delayed
rule processor needs to callget_rate
with bulk Snuba queries (see this code block), so this PR refactorsget_rate
to handle that.